Attachment 339733 Details for Bug 185384 – Patch

[patch] Patch

bug-185384-20180507112345.patch (text/plain), 1.63 KB, created by youenn fablet on 2018-05-07 11:23:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-07 11:23:45 PDT

Size: 1.63 KB

patch

obsolete

>Subversion Revision: 231437
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index c898d3795aad6b0628fc521d8da2690b48512b28..752ca1310b2ec163d8b661293dc8681f4122b0c5 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-07  Youenn Fablet  <youenn@apple.com>
>+
>+        Layout Test webrtc/addICECandidate-closed.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=185384
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Given that we are calling addIceCandidate and close the peer connection,
>+        addIceCandidate might throw an error sometimes.
>+        Catch the exception to make the test output stable.
>+
>+        * webrtc/addICECandidate-closed.html:
>+
> 2018-05-04  Youenn Fablet  <youenn@apple.com>
> 
>         webrtc/addICECandidate-closed.html is timing out
>diff --git a/LayoutTests/webrtc/addICECandidate-closed.html b/LayoutTests/webrtc/addICECandidate-closed.html
>index 57dfd168d0b87dbaaf8b38bf6187aa6ccddc1b18..d4bfc77017b23cd6ed85d459107d4080c0eeb81c 100644
>--- a/LayoutTests/webrtc/addICECandidate-closed.html
>+++ b/LayoutTests/webrtc/addICECandidate-closed.html
>@@ -15,8 +15,10 @@ promise_test(async (test) => {
>         const localTracks = stream.getTracks();
>         [[sender, receiver], [receiver, sender]].forEach(([pc1, pc2]) => {
>             pc1.onicecandidate = ({ candidate }) => {
>-                if (candidate)
>-                    pc2.addIceCandidate(candidate);
>+                try {
>+                    if (candidate)
>+                        pc2.addIceCandidate(candidate);
>+                } catch (e) { }
>                 pc1.close();
>             };
>         });

Actions: View | Formatted Diff | Diff

Attachments on bug 185384: 339733 | 340175 | 340187 | 340465