Attachment 339657 Details for Bug 185353 – Proposed patch

[patch] Proposed patch

log_cue_text.txt (text/plain), 4.22 KB, created by Eric Carlson on 2018-05-05 15:10:41 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2018-05-05 15:10:41 PDT

Size: 4.22 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 99990c71c2b..d14df6d09fe 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,24 @@
>+2018-05-05  Eric Carlson  <eric.carlson@apple.com>
>+
>+        Text track cue logging should include cue text
>+        https://bugs.webkit.org/show_bug.cgi?id=185353
>+        <rdar://problem/40003565>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests, tested manually.
>+
>+        * html/track/VTTCue.cpp:
>+        (WebCore::VTTCue::toJSONString const): Use toJSON.
>+        (WebCore::VTTCue::toJSON const): New.
>+        * html/track/VTTCue.h:
>+
>+        * platform/graphics/InbandTextTrackPrivateClient.h:
>+        (WebCore::GenericCueData::toJSONString const): Log m_content.
>+
>+        * platform/graphics/iso/ISOVTTCue.cpp:
>+        (WebCore::ISOWebVTTCue::toJSONString const): Log m_cueText.
>+
> 2018-05-04  Zalan Bujtas  <zalan@apple.com>
> 
>         [Simple line layout] Add support for line layout box generation with multiple text renderers.
>diff --git a/Source/WebCore/html/track/VTTCue.cpp b/Source/WebCore/html/track/VTTCue.cpp
>index 78f8adfc37e..ed03bb874c4 100644
>--- a/Source/WebCore/html/track/VTTCue.cpp
>+++ b/Source/WebCore/html/track/VTTCue.cpp
>@@ -1182,21 +1182,26 @@ const VTTCue* toVTTCue(const TextTrackCue* cue)
> String VTTCue::toJSONString() const
> {
>     auto object = JSON::Object::create();
>-
>-    TextTrackCue::toJSON(object.get());
>-
>-    object->setString(ASCIILiteral("vertical"), vertical());
>-    object->setBoolean(ASCIILiteral("snapToLines"), snapToLines());
>-    object->setDouble(ASCIILiteral("line"), m_linePosition);
>-    object->setDouble(ASCIILiteral("position"), position());
>-    object->setInteger(ASCIILiteral("size"), m_cueSize);
>-    object->setString(ASCIILiteral("align"), align());
>-    object->setString(ASCIILiteral("text"), text());
>-    object->setString(ASCIILiteral("regionId"), regionId());
>+    toJSON(object.get());
> 
>     return object->toJSONString();
> }
> 
>+void VTTCue::toJSON(JSON::Object& object) const
>+{
>+    TextTrackCue::toJSON(object);
>+
>+    object.setString(ASCIILiteral("text"), text());
>+    object.setString(ASCIILiteral("vertical"), vertical());
>+    object.setBoolean(ASCIILiteral("snapToLines"), snapToLines());
>+    object.setDouble(ASCIILiteral("line"), m_linePosition);
>+    object.setDouble(ASCIILiteral("position"), position());
>+    object.setInteger(ASCIILiteral("size"), m_cueSize);
>+    object.setString(ASCIILiteral("align"), align());
>+    object.setString(ASCIILiteral("text"), text());
>+    object.setString(ASCIILiteral("regionId"), regionId());
>+}
>+
> } // namespace WebCore
> 
> #endif
>diff --git a/Source/WebCore/html/track/VTTCue.h b/Source/WebCore/html/track/VTTCue.h
>index 3d968d62add..539046d008f 100644
>--- a/Source/WebCore/html/track/VTTCue.h
>+++ b/Source/WebCore/html/track/VTTCue.h
>@@ -177,6 +177,8 @@ protected:
>     virtual Ref<VTTCueBox> createDisplayTree();
>     VTTCueBox& displayTreeInternal();
> 
>+    virtual void toJSON(JSON::Object&) const;
>+
> private:
>     void initialize(ScriptExecutionContext&);
>     void createWebVTTNodeTree();
>diff --git a/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h b/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h
>index ccbb3d655f9..bc5c427f758 100644
>--- a/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h
>+++ b/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h
>@@ -120,6 +120,7 @@ inline String GenericCueData::toJSONString() const
> {
>     auto object = JSON::Object::create();
> 
>+    object->setString("text", m_content);
>     object->setDouble(ASCIILiteral("start"), m_startTime.toDouble());
>     object->setDouble(ASCIILiteral("end"), m_endTime.toDouble());
> 
>diff --git a/Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp b/Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp
>index a063bd22a36..327fe9a7c76 100644
>--- a/Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp
>+++ b/Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp
>@@ -114,6 +114,7 @@ String ISOWebVTTCue::toJSONString() const
> {
>     auto object = JSON::Object::create();
> 
>+    object->setString(ASCIILiteral("text"), m_cueText);
>     object->setString(ASCIILiteral("sourceId"), m_sourceID);
>     object->setString(ASCIILiteral("id"), m_identifier);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185353: 339657 | 339667 | 339720 | 339753