Attachment 339649 Details for Bug 185354 – the patch

[patch] the patch

blah.patch (text/plain), 1.53 KB, created by Filip Pizlo on 2018-05-05 10:52:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2018-05-05 10:52:00 PDT

Size: 1.53 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 231396)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-05-05  Filip Pizlo  <fpizlo@apple.com>
>+
>+        DFG CFA phase should only do clobber asserts in debug
>+        https://bugs.webkit.org/show_bug.cgi?id=185354
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        Clobber asserts are responsible for 1% of compile time. That's too much. This disables them
>+        unless asserts are enabled.
>+
>+        * dfg/DFGCFAPhase.cpp:
>+        (JSC::DFG::CFAPhase::performBlockCFA):
>+
> 2018-05-04  Keith Miller  <keith_miller@apple.com>
> 
>         isCacheableArrayLength should return true for undecided arrays
>Index: Source/JavaScriptCore/dfg/DFGCFAPhase.cpp
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGCFAPhase.cpp	(revision 231338)
>+++ Source/JavaScriptCore/dfg/DFGCFAPhase.cpp	(working copy)
>@@ -181,7 +181,8 @@ private:
>                 break;
>             }
>             
>-            if (m_state.didClobberOrFolded() != writesOverlap(m_graph, node, JSCell_structureID))
>+            if (!ASSERT_DISABLED
>+                && m_state.didClobberOrFolded() != writesOverlap(m_graph, node, JSCell_structureID))
>                 DFG_CRASH(m_graph, node, toCString("AI-clobberize disagreement; AI says ", m_state.clobberState(), " while clobberize says ", writeSet(m_graph, node)).data());
>         }
>         if (m_verbose) {

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185354: 339649