Attachment 339617 Details for Bug 185336 – Patch

[patch] Patch

bug-185336-20180504171933.patch (text/plain), 2.38 KB, created by youenn fablet on 2018-05-04 17:19:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-04 17:19:33 PDT

Size: 2.38 KB

patch

obsolete

>Subversion Revision: 231370
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e45da7f840ff999b3d2d98a320f6b42532d5fa16..68af5d85507598ce8bb170c8455d2247ec936847 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-04  Youenn Fablet  <youenn@apple.com>
>+
>+        webrtc/addICECandidate-closed.html is timing out
>+        https://bugs.webkit.org/show_bug.cgi?id=185336
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * webrtc/addICECandidate-closed.html:
>+
> 2018-05-04  Youenn Fablet  <youenn@apple.com>
> 
>         REGRESSION (r230326?): Layout Test http/tests/contentextensions/make-https.html is a flaky failure
>diff --git a/LayoutTests/webrtc/addICECandidate-closed.html b/LayoutTests/webrtc/addICECandidate-closed.html
>index 2f5a6d695007355434078394b0b766850a556f7b..57dfd168d0b87dbaaf8b38bf6187aa6ccddc1b18 100644
>--- a/LayoutTests/webrtc/addICECandidate-closed.html
>+++ b/LayoutTests/webrtc/addICECandidate-closed.html
>@@ -28,13 +28,21 @@ promise_test(async (test) => {
>         await receiver.setRemoteDescription(offer1);
>         const answer1 = await receiver.createAnswer();
>         await receiver.setLocalDescription(answer1);
>-        await sender.setRemoteDescription(answer1);
>-        const offer2 = await sender.createOffer();
>-        await sender.setLocalDescription(offer2);
>-        await receiver.setRemoteDescription(offer2);
>-        const answer2 = await receiver.createAnswer();
>-        await receiver.setLocalDescription(answer2);
>-        await sender.setRemoteDescription(answer2);
>+        await new Promise (async (resolve) => {
>+            // RTCPeerConnection does not resolve promises when it gets closed, hence the timeout here to make sure we execute some if not all these operations.
>+            test.step_timeout(resolve, 100);
>+            try {
>+                await sender.setRemoteDescription(answer1);
>+                const offer2 = await sender.createOffer();
>+                await sender.setLocalDescription(offer2);
>+                await receiver.setRemoteDescription(offer2);
>+                const answer2 = await receiver.createAnswer();
>+                await receiver.setLocalDescription(answer2);
>+                await sender.setRemoteDescription(answer2);
>+            } finally {
>+                resolve();
>+            }
>+        });
>     } catch (e) {
>     }
> }, "Close a peer connection in the middle of gathering");

Actions: View | Formatted Diff | Diff

Attachments on bug 185336: 339617