Attachment 339579 Details for Bug 185316 – Patch

[patch] Patch

bug-185316-20180504160821.patch (text/plain), 2.02 KB, created by Leo Balter on 2018-05-04 12:08:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-05-04 12:08:22 PDT

Size: 2.02 KB

patch

obsolete

>Subversion Revision: 231369
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 836c9d616f95bb7dabe5cba67a8f3d4480862f47..f7eb843e5b08cf47ad84264227e04d6f3f0db7be 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        Fix Tools/Scripts/webkitdirs.pm for retrocompatibility
>+        https://bugs.webkit.org/show_bug.cgi?id=185316
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitdirs.pm:
>+        (buildVisualStudioProject):
>+
> 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
> 
>         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
>diff --git a/Tools/Scripts/webkitdirs.pm b/Tools/Scripts/webkitdirs.pm
>index 8f48811f0fb7d8686eeedb691cef7da7fbb57f85..2a69a04d21cdb66d5bd8e2f3b496422492999532 100755
>--- a/Tools/Scripts/webkitdirs.pm
>+++ b/Tools/Scripts/webkitdirs.pm
>@@ -30,7 +30,6 @@
> # Module to share code to get to WebKit directories.
> 
> use strict;
>-use version;
> use warnings;
> use Config;
> use Cwd qw(realpath);
>@@ -38,7 +37,7 @@ use Digest::MD5 qw(md5_hex);
> use FindBin;
> use File::Basename;
> use File::Find;
>-use File::Path qw(make_path mkpath rmtree);
>+use File::Path qw(mkpath rmtree);
> use File::Spec;
> use File::Temp qw(tempdir);
> use File::stat;
>@@ -49,8 +48,7 @@ use VCSUtils;
> 
> BEGIN {
>    use Exporter   ();
>-   our ($VERSION, @ISA, @EXPORT, @EXPORT_OK, %EXPORT_TAGS);
>-   $VERSION     = 1.00;
>+   our (@ISA, @EXPORT, @EXPORT_OK, %EXPORT_TAGS);
>    @ISA         = qw(Exporter);
>    @EXPORT      = qw(
>        &XcodeCoverageSupportOptions
>@@ -1924,7 +1922,7 @@ sub buildVisualStudioProject
> 
>     my $platform = "/p:Platform=" . (isWin64() ? "x64" : "Win32");
>     my $logPath = File::Spec->catdir($baseProductDir, $configuration);
>-    make_path($logPath) unless -d $logPath or $logPath eq ".";
>+    mkpath($logPath) unless -d $logPath or $logPath eq ".";
> 
>     my $errorLogFile = File::Spec->catfile($logPath, "webkit_errors.log");
>     chomp($errorLogFile = `cygpath -w "$errorLogFile"`) if isCygwin();

Flags:

ap: review-
ap: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 185316: 339579