Attachment 339572 Details for Bug 184196 – Patch

[patch] Patch

bug-184196-20180504112931.patch (text/plain), 5.42 KB, created by Wenson Hsieh on 2018-05-04 11:29:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-05-04 11:29:32 PDT

Size: 5.42 KB

patch

obsolete

>Subversion Revision: 231347
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 7c3e7e63389bae7f19a5f42b6a84f59fb8663b91..680c678a8c1b22ae169014da5eaf172b62c7d8fb 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
>+
>+        REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
>+        https://bugs.webkit.org/show_bug.cgi?id=184196
>+        <rdar://problem/39054481>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove an unnecessary call to NSClassFromString, now that trunk WebKit only supports iOS 11.3+.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView insertTextSuggestion:]):
>+
> 2018-05-03  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         Use default std::optional if it is provided
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index c2a3bade11331b8af0acf540acfd8d19af6c56c4..c6bf0a97296f6b1c133cb6e9ff5579305de6e3d8 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -3149,7 +3149,7 @@ static void selectionChangedWithTouch(WKContentView *view, const WebCore::IntPoi
> - (void)insertTextSuggestion:(UITextSuggestion *)textSuggestion
> {
>     // FIXME: Replace NSClassFromString with actual class as soon as UIKit submitted the new class into the iOS SDK.
>-    if ([textSuggestion isKindOfClass:NSClassFromString(@"UITextAutofillSuggestion")]) {
>+    if ([textSuggestion isKindOfClass:[UITextAutofillSuggestion class]]) {
>         _page->autofillLoginCredentials([(UITextAutofillSuggestion *)textSuggestion username], [(UITextAutofillSuggestion *)textSuggestion password]);
>         return;
>     }
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 1aec63c77debe730d7e92bc04b3bb44c03473006..46fc5da644ddb2b2e33b992a4c63fd55ead09f2c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
>+
>+        REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
>+        https://bugs.webkit.org/show_bug.cgi?id=184196
>+        <rdar://problem/39054481>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
>+        earlier than 11.3. Also re-enables these tests.
>+
>+        * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
>+        (TestWebKitAPI::TEST):
>+        (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
>+        (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
>+
> 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         [WinCairo] Test archive must use Python zipfile, just like build product.
>diff --git a/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm b/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm
>index 1730532c48a174f6a0938dc98680295f26ef012e..ba375a7f3b5345a70d8a4a62abf8917b76e69cc5 100644
>--- a/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm
>+++ b/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm
>@@ -35,26 +35,6 @@
> #import <WebKit/_WKInputDelegate.h>
> #import <wtf/BlockPtr.h>
> 
>-#if !__has_include(<UIKit/UITextAutofillSuggestion.h>)
>-// FIXME: This can be safely removed once <rdar://problem/34583628> lands in the SDK.
>-@implementation UITextAutofillSuggestion
>-- (instancetype)initWithUsername:(NSString *)username password:(NSString *)password
>-{
>-    self = [super init];
>-    if (self) {
>-        _username = username;
>-        _password = password;
>-    }
>-    return self;
>-}
>-
>-+ (instancetype)autofillSuggestionWithUsername:(NSString *)username password:(NSString *)password
>-{
>-    return [[self alloc] initWithUsername:username password:password];
>-}
>-@end
>-#endif
>-
> typedef UIView <UITextInputTraits_Private_Proposed_SPI_34583628> AutofillInputView;
> 
> @interface TestInputDelegate : NSObject <_WKInputDelegate>
>@@ -115,7 +95,7 @@ typedef UIView <UITextInputTraits_Private_Proposed_SPI_34583628> AutofillInputVi
> 
> namespace TestWebKitAPI {
> 
>-TEST(WKWebViewAutofillTests, DISABLED_UsernameAndPasswordField)
>+TEST(WKWebViewAutofillTests, UsernameAndPasswordField)
> {
>     auto webView = adoptNS([[AutofillTestView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
>     [webView synchronouslyLoadHTMLString:@"<input id='user' type='email'><input id='password' type='password'>"];
>@@ -134,7 +114,7 @@ TEST(WKWebViewAutofillTests, DISABLED_UsernameAndPasswordField)
>     EXPECT_FALSE([webView textInputHasAutofillContext]);
> }
> 
>-TEST(WKWebViewAutofillTests, DISABLED_UsernameAndPasswordFieldSeparatedByRadioButton)
>+TEST(WKWebViewAutofillTests, UsernameAndPasswordFieldSeparatedByRadioButton)
> {
>     auto webView = adoptNS([[AutofillTestView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
>     [webView synchronouslyLoadHTMLString:@"<input id='user' type='email'><input type='radio' name='radio_button' value='radio'><input id='password' type='password'>"];
>@@ -165,7 +145,7 @@ TEST(WKWebViewAutofillTests, TwoTextFields)
>     EXPECT_FALSE([webView textInputHasAutofillContext]);
> }
> 
>-TEST(WKWebViewAutofillTests, DISABLED_StandalonePasswordField)
>+TEST(WKWebViewAutofillTests, StandalonePasswordField)
> {
>     auto webView = adoptNS([[AutofillTestView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
>     [webView synchronouslyLoadHTMLString:@"<input id='password' type='password'>"];

Actions: View | Formatted Diff | Diff

Attachments on bug 184196: 339572