Attachment 339553 Details for Bug 185303 – Patch

[patch] Patch

bug-185303-20180504093252.patch (text/plain), 1.73 KB, created by youenn fablet on 2018-05-04 09:32:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-04 09:32:52 PDT

Size: 1.73 KB

patch

obsolete

>Subversion Revision: 231318
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 06279fb136ae89953b6b08217733fbc9271250be..c803e59e31972670cd812de7f36cf11d44ca87a4 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-04  Youenn Fablet  <youenn@apple.com>
>+
>+        LayoutTests/fast/mediastream/change-tracks-media-stream-being-played.html is crashing after r231304
>+        https://bugs.webkit.org/show_bug.cgi?id=185303
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We need to stop observing the audio track like we do for video track once we are no longer interested in it.
>+        Covered by test no longer crashing.
>+
>+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
>+        (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
>+
> 2018-05-03  Youenn Fablet  <youenn@apple.com>
> 
>         Allow WebResourceLoader to cancel a load served from a service worker
>diff --git a/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm b/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
>index 9bafb62701973d22e0df501e5f37733fd4c77228..00ee7cd9fc2bcba5957297873fe9a169f15b7c9a 100644
>--- a/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
>+++ b/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
>@@ -996,6 +996,7 @@ void MediaPlayerPrivateMediaStreamAVFObjC::updateTracks()
>     {
>         switch (state) {
>         case TrackState::Remove:
>+            track->streamTrack().removeObserver(*this);
>             m_player->removeAudioTrack(*track);
>             break;
>         case TrackState::Add:

Actions: View | Formatted Diff | Diff

Attachments on bug 185303: 339553