Attachment 339548 Details for Bug 185302 – Patch

[patch] Patch

bug-185302-20180504090622.patch (text/plain), 8.85 KB, created by youenn fablet on 2018-05-04 09:06:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-04 09:06:23 PDT

Size: 8.85 KB

patch

obsolete

>Subversion Revision: 231318
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 088aba27778f94dc1d41db097209bde684be6b69..dd2a44af0291c0ac7a3a3becb3bfd9392ac00bfb 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,24 @@
>+2018-05-04  Youenn Fablet  <youenn@apple.com>
>+
>+        NetworkProcessProxy::didReceiveAuthenticationChallenge should take an AuthenticationChallenge r-value
>+        https://bugs.webkit.org/show_bug.cgi?id=185302
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Pass AuthenticationChallenge as an r-value since it comes from IPC.
>+        No change of behavior.
>+
>+        * UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
>+        (WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
>+        * UIProcess/Authentication/AuthenticationChallengeProxy.h:
>+        (WebKit::AuthenticationChallengeProxy::create):
>+        * UIProcess/Downloads/DownloadProxy.cpp:
>+        (WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
>+        * UIProcess/Downloads/DownloadProxy.h:
>+        * UIProcess/Network/NetworkProcessProxy.cpp:
>+        (WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):
>+        * UIProcess/Network/NetworkProcessProxy.h:
>+
> 2018-05-03  Youenn Fablet  <youenn@apple.com>
> 
>         Allow WebResourceLoader to cancel a load served from a service worker
>diff --git a/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp b/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp
>index 9bdd73b445efa0f13b6b32ffaa196a4b62430913..2b75a0ba036f04f0a7a9f31fab0bff01ac3ac51d 100644
>--- a/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp
>+++ b/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp
>@@ -37,8 +37,8 @@
> 
> namespace WebKit {
> 
>-AuthenticationChallengeProxy::AuthenticationChallengeProxy(const WebCore::AuthenticationChallenge& authenticationChallenge, uint64_t challengeID, IPC::Connection* connection)
>-    : m_coreAuthenticationChallenge(authenticationChallenge)
>+AuthenticationChallengeProxy::AuthenticationChallengeProxy(WebCore::AuthenticationChallenge&& authenticationChallenge, uint64_t challengeID, IPC::Connection* connection)
>+    : m_coreAuthenticationChallenge(WTFMove(authenticationChallenge))
>     , m_challengeID(challengeID)
>     , m_connection(connection)
> {
>diff --git a/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h b/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h
>index 8b65baa791b8c94cd03466865b0bf8b8e56cd49b..0c5be5e446d875955dd982e52577a98852ad1abe 100644
>--- a/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h
>+++ b/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h
>@@ -41,9 +41,9 @@ class WebProtectionSpace;
> 
> class AuthenticationChallengeProxy : public API::ObjectImpl<API::Object::Type::AuthenticationChallenge> {
> public:
>-    static Ref<AuthenticationChallengeProxy> create(const WebCore::AuthenticationChallenge& authenticationChallenge, uint64_t challengeID, IPC::Connection* connection)
>+    static Ref<AuthenticationChallengeProxy> create(WebCore::AuthenticationChallenge&& authenticationChallenge, uint64_t challengeID, IPC::Connection* connection)
>     {
>-        return adoptRef(*new AuthenticationChallengeProxy(authenticationChallenge, challengeID, connection));
>+        return adoptRef(*new AuthenticationChallengeProxy(WTFMove(authenticationChallenge), challengeID, connection));
>     }
>     
>     ~AuthenticationChallengeProxy();
>@@ -60,7 +60,7 @@ public:
>     const WebCore::AuthenticationChallenge& core() { return m_coreAuthenticationChallenge; }
> 
> private:
>-    AuthenticationChallengeProxy(const WebCore::AuthenticationChallenge&, uint64_t challengeID, IPC::Connection*);
>+    AuthenticationChallengeProxy(WebCore::AuthenticationChallenge&&, uint64_t challengeID, IPC::Connection*);
> 
>     WebCore::AuthenticationChallenge m_coreAuthenticationChallenge;
>     uint64_t m_challengeID;
>diff --git a/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp b/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp
>index 10f75514d6c57650972baa173710bb390938a0e4..28dac213887d251b9165a6e46836963de4cb1b6f 100644
>--- a/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp
>+++ b/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp
>@@ -116,12 +116,12 @@ void DownloadProxy::didStart(const ResourceRequest& request, const String& sugge
>     m_processPool->downloadClient().didStart(*m_processPool, *this);
> }
> 
>-void DownloadProxy::didReceiveAuthenticationChallenge(const AuthenticationChallenge& authenticationChallenge, uint64_t challengeID)
>+void DownloadProxy::didReceiveAuthenticationChallenge(AuthenticationChallenge&& authenticationChallenge, uint64_t challengeID)
> {
>     if (!m_processPool)
>         return;
> 
>-    auto authenticationChallengeProxy = AuthenticationChallengeProxy::create(authenticationChallenge, challengeID, m_processPool->networkingProcessConnection());
>+    auto authenticationChallengeProxy = AuthenticationChallengeProxy::create(WTFMove(authenticationChallenge), challengeID, m_processPool->networkingProcessConnection());
> 
>     m_processPool->downloadClient().didReceiveAuthenticationChallenge(*m_processPool, *this, authenticationChallengeProxy.get());
> }
>diff --git a/Source/WebKit/UIProcess/Downloads/DownloadProxy.h b/Source/WebKit/UIProcess/Downloads/DownloadProxy.h
>index 96ab7491f3fcc3a9700d3f837410da42615818a8..f258633c60fa67329307162965920d57cc838ed6 100644
>--- a/Source/WebKit/UIProcess/Downloads/DownloadProxy.h
>+++ b/Source/WebKit/UIProcess/Downloads/DownloadProxy.h
>@@ -88,7 +88,7 @@ private:
> 
>     // Message handlers.
>     void didStart(const WebCore::ResourceRequest&, const String& suggestedFilename);
>-    void didReceiveAuthenticationChallenge(const WebCore::AuthenticationChallenge&, uint64_t challengeID);
>+    void didReceiveAuthenticationChallenge(WebCore::AuthenticationChallenge&&, uint64_t challengeID);
>     void didReceiveResponse(const WebCore::ResourceResponse&);
>     void didReceiveData(uint64_t length);
>     void shouldDecodeSourceDataOfMIMEType(const String& mimeType, bool& result);
>diff --git a/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp b/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
>index 6b3287bf842519b706aae4f80da906a59d47e78e..bb5f4ebe2e9fe94af78d9d215dd2e28d28a0e406 100644
>--- a/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
>+++ b/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
>@@ -293,11 +293,11 @@ void NetworkProcessProxy::didCreateNetworkConnectionToWebProcess(const IPC::Atta
> #endif
> }
> 
>-void NetworkProcessProxy::didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, const WebCore::AuthenticationChallenge& coreChallenge, uint64_t challengeID)
>+void NetworkProcessProxy::didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, WebCore::AuthenticationChallenge&& coreChallenge, uint64_t challengeID)
> {
> #if ENABLE(SERVICE_WORKER)
>     if (auto* serviceWorkerProcessProxy = m_processPool.serviceWorkerProcessProxyFromPageID(pageID)) {
>-        auto authenticationChallenge = AuthenticationChallengeProxy::create(coreChallenge, challengeID, connection());
>+        auto authenticationChallenge = AuthenticationChallengeProxy::create(WTFMove(coreChallenge), challengeID, connection());
>         serviceWorkerProcessProxy->didReceiveAuthenticationChallenge(pageID, frameID, WTFMove(authenticationChallenge));
>         return;
>     }
>@@ -306,7 +306,7 @@ void NetworkProcessProxy::didReceiveAuthenticationChallenge(uint64_t pageID, uin
>     WebPageProxy* page = WebProcessProxy::webPage(pageID);
>     MESSAGE_CHECK(page);
> 
>-    auto authenticationChallenge = AuthenticationChallengeProxy::create(coreChallenge, challengeID, connection());
>+    auto authenticationChallenge = AuthenticationChallengeProxy::create(WTFMove(coreChallenge), challengeID, connection());
>     page->didReceiveAuthenticationChallengeProxy(frameID, WTFMove(authenticationChallenge));
> }
> 
>diff --git a/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h b/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
>index c9dc792a9b5e07ccfe10529a7e19ae6aba490d97..e3b32873660d8182bf1249c6d06b6702e73740b5 100644
>--- a/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
>+++ b/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
>@@ -128,7 +128,7 @@ private:
>     // Message handlers
>     void didReceiveNetworkProcessProxyMessage(IPC::Connection&, IPC::Decoder&);
>     void didCreateNetworkConnectionToWebProcess(const IPC::Attachment&);
>-    void didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, const WebCore::AuthenticationChallenge&, uint64_t challengeID);
>+    void didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, WebCore::AuthenticationChallenge&&, uint64_t challengeID);
>     void didFetchWebsiteData(uint64_t callbackID, const WebsiteData&);
>     void didDeleteWebsiteData(uint64_t callbackID);
>     void didDeleteWebsiteDataForOrigins(uint64_t callbackID);

Actions: View | Formatted Diff | Diff

Attachments on bug 185302: 339548