Attachment 339535 Details for Bug 185296 – Patch

[patch] Patch

bug-185296-20180504123309.patch (text/plain), 1.88 KB, created by Dominik Inführ on 2018-05-04 03:33:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dominik Inführ

Created: 2018-05-04 03:33:10 PDT

Size: 1.88 KB

patch

obsolete

>Subversion Revision: 231302
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index 23aede92fb3ff1513a286e6eb803f842ec75245b..fbbe1936981a5d7b8e3334f8f4e9d4ce5c13be0c 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-04  Dominik Infuehr  <dinfuehr@igalia.com>
>+
>+        Disable tests on systems with limited memory
>+        https://bugs.webkit.org/show_bug.cgi?id=185296
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        These tests don't work with a limited amount of memory. I tried to reduce
>+        memory usage for them but then it was hard to reproduce the failures they were
>+        testing for.
>+
>+        * slowMicrobenchmarks/function-constructor-with-huge-strings.js:
>+        * stress/array-reverse-doesnt-clobber.js:
>+
> 2018-05-02  Filip Pizlo  <fpizlo@apple.com>
> 
>         JSC should know how to cache custom getter accesses on the prototype chain
>diff --git a/JSTests/slowMicrobenchmarks/function-constructor-with-huge-strings.js b/JSTests/slowMicrobenchmarks/function-constructor-with-huge-strings.js
>index 265cead6df8867976428d9beab037ada4f2959f1..515304983d9142a01b931548d2ec3b0d7713744a 100644
>--- a/JSTests/slowMicrobenchmarks/function-constructor-with-huge-strings.js
>+++ b/JSTests/slowMicrobenchmarks/function-constructor-with-huge-strings.js
>@@ -1,3 +1,5 @@
>+//@ skip if $memoryLimited
>+
> var hugeString = "x";
> for (i = 0; i < 25; ++i) {
>     hugeString += hugeString;
>diff --git a/JSTests/stress/array-reverse-doesnt-clobber.js b/JSTests/stress/array-reverse-doesnt-clobber.js
>index 3b82ed45157591bc3076ea7c1c3abbbb52c45bb7..c98a4b5d1f46416c7fca7fc7dc69a34168897b64 100644
>--- a/JSTests/stress/array-reverse-doesnt-clobber.js
>+++ b/JSTests/stress/array-reverse-doesnt-clobber.js
>@@ -1,3 +1,5 @@
>+//@ skip if $memoryLimited
>+
> // This tests that array.Prototype.reverse() doesn't inadvertently clobber indexed properties.
> // This test shouldn't throw or crash.
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185296: 339535 | 339538