Attachment 339512 Details for Bug 185289 – Patch

[patch] Patch

bug-185289-20180503202323.patch (text/plain), 6.66 KB, created by Wenson Hsieh on 2018-05-03 20:23:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-05-03 20:23:23 PDT

Size: 6.66 KB

patch

obsolete

>Subversion Revision: 231220
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d6feeb697fd8b46cbfc5b18eb48e406d2f99a6c3..47aa33f356752a5f07edd1c2e85ecf5f411f102e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,24 @@
>+2018-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
>+        https://bugs.webkit.org/show_bug.cgi?id=185289
>+        <rdar://problem/35756912>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When inserting multiple URLs as individual items in a single drop, we currently separate each item with a space
>+        (see r217284). However, it still seems difficult to tell dropped links apart. This patch makes some slight
>+        tweaks to WebContentReader::readURL so that it inserts line breaks before dropped URLs, if the dropped URL isn't
>+        the first item to be inserted in the resulting document fragment.
>+
>+        Augments existing API tests in DataInteractionTests.
>+
>+        * editing/ios/WebContentReaderIOS.mm:
>+
>+        Additionally remove some extraneous header imports from this implementation file.
>+
>+        (WebCore::WebContentReader::readURL):
>+
> 2018-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Unreviewed, remove an unused variable in RuntimeEnabledFeatures.h
>diff --git a/Source/WebCore/editing/ios/WebContentReaderIOS.mm b/Source/WebCore/editing/ios/WebContentReaderIOS.mm
>index 9b310d56c68dd93ce17e93e78628dd4ec32b3808..8de5c15006cb9a9d833e18795af0a2e74704cb0c 100644
>--- a/Source/WebCore/editing/ios/WebContentReaderIOS.mm
>+++ b/Source/WebCore/editing/ios/WebContentReaderIOS.mm
>@@ -28,24 +28,14 @@
> 
> #if PLATFORM(IOS)
> 
>-#import "ArchiveResource.h"
> #import "Document.h"
> #import "DocumentFragment.h"
>-#import "DocumentLoader.h"
> #import "Editor.h"
> #import "EditorClient.h"
>-#import "FragmentScriptingPermission.h"
>-#import "FrameLoader.h"
>-#import "FrameLoaderClient.h"
> #import "HTMLAnchorElement.h"
>+#import "HTMLBRElement.h"
> #import "HTMLNames.h"
>-#import "LegacyWebArchive.h"
>-#import "MIMETypeRegistry.h"
> #import "Text.h"
>-#import "UTIUtilities.h"
>-#import "markup.h"
>-#import <MobileCoreServices/MobileCoreServices.h>
>-#import <wtf/unicode/CharacterNames.h>
> 
> namespace WebCore {
> 
>@@ -63,15 +53,16 @@ bool WebContentReader::readURL(const URL& url, const String& title)
>     if ([(NSURL *)url isFileURL])
>         return false;
> 
>-    auto anchor = HTMLAnchorElement::create(*frame.document());
>+    auto document = makeRef(*frame.document());
>+    auto anchor = HTMLAnchorElement::create(document.get());
>     anchor->setAttributeWithoutSynchronization(HTMLNames::hrefAttr, url.string());
> 
>     String linkText = title.length() ? title : String([[(NSURL *)url absoluteString] precomposedStringWithCanonicalMapping]);
>-    anchor->appendChild(frame.document()->createTextNode(linkText));
>+    anchor->appendChild(document->createTextNode(linkText));
> 
>-    auto newFragment = frame.document()->createDocumentFragment();
>+    auto newFragment = document->createDocumentFragment();
>     if (fragment)
>-        newFragment->appendChild(Text::create(*frame.document(), { &space, 1 }));
>+        newFragment->appendChild(HTMLBRElement::create(document.get()));
>     newFragment->appendChild(anchor);
>     addFragment(WTFMove(newFragment));
>     return true;
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 55e127af1a6cd54abbfd07b167051124c969576d..2c18a1d459afa692576b980c15e4d9e4756ceeb3 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
>+        https://bugs.webkit.org/show_bug.cgi?id=185289
>+        <rdar://problem/35756912>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
>+        sessions.
>+
>+        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
>+        (TestWebKitAPI::TEST):
>+
> 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
> 
>         Auto save the results for Test262
>diff --git a/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm b/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
>index 4a348c2504e77625c3eff344f6bcdd97de1a594f..bf0d9295bfce882dccc05b5b49ec2081831b156a 100644
>--- a/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
>+++ b/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
>@@ -856,11 +856,17 @@ TEST(DataInteractionTests, ExternalSourceMultipleURLsToContentEditable)
>     [dataInteractionSimulator setExternalItemProviders:@[ firstItem.get(), secondItem.get(), thirdItem.get() ]];
>     [dataInteractionSimulator runFrom:CGPointMake(300, 400) to:CGPointMake(100, 300)];
> 
>-    NSArray *separatedLinks = [[webView stringByEvaluatingJavaScript:@"editor.textContent"] componentsSeparatedByCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
>-    EXPECT_EQ(3UL, separatedLinks.count);
>-    EXPECT_WK_STREQ("https://www.apple.com/iphone/", separatedLinks[0]);
>-    EXPECT_WK_STREQ("https://www.apple.com/mac/", separatedLinks[1]);
>-    EXPECT_WK_STREQ("https://webkit.org/", separatedLinks[2]);
>+    NSArray *droppedURLs = [webView objectByEvaluatingJavaScript:@"Array.from(editor.querySelectorAll('a')).map(a => a.href)"];
>+    EXPECT_EQ(3UL, droppedURLs.count);
>+    EXPECT_WK_STREQ("https://www.apple.com/iphone/", droppedURLs[0]);
>+    EXPECT_WK_STREQ("https://www.apple.com/mac/", droppedURLs[1]);
>+    EXPECT_WK_STREQ("https://webkit.org/", droppedURLs[2]);
>+
>+    NSArray *linksSeparatedByLine = [[webView objectByEvaluatingJavaScript:@"editor.innerText"] componentsSeparatedByCharactersInSet:[NSCharacterSet newlineCharacterSet]];
>+    EXPECT_EQ(3UL, linksSeparatedByLine.count);
>+    EXPECT_WK_STREQ("https://www.apple.com/iphone/", linksSeparatedByLine[0]);
>+    EXPECT_WK_STREQ("https://www.apple.com/mac/", linksSeparatedByLine[1]);
>+    EXPECT_WK_STREQ("https://webkit.org/", linksSeparatedByLine[2]);
> }
> 
> TEST(DataInteractionTests, RespectsExternalSourceFidelityRankings)
>@@ -1466,7 +1472,7 @@ TEST(DataInteractionTests, AdditionalLinkAndImageIntoContentEditable)
>         @0.33: [NSValue valueWithCGPoint:CGPointMake(50, 150)],
>         @0.66: [NSValue valueWithCGPoint:CGPointMake(50, 250)]
>     }];
>-    EXPECT_WK_STREQ("ABCD A link", [webView stringByEvaluatingJavaScript:@"editor.textContent"]);
>+    EXPECT_WK_STREQ("ABCDA link", [webView stringByEvaluatingJavaScript:@"editor.textContent"]);
>     EXPECT_TRUE([webView stringByEvaluatingJavaScript:@"!!editor.querySelector('img')"]);
>     EXPECT_WK_STREQ("https://www.apple.com/", [webView stringByEvaluatingJavaScript:@"editor.querySelector('a').href"]);
> }

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185289: 339512 | 339626