Attachment 339511 Details for Bug 185262 – Patch

[patch] Patch

bug-185262-20180503202106.patch (text/plain), 1.83 KB, created by Sihui Liu on 2018-05-03 20:21:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-05-03 20:21:07 PDT

Size: 1.83 KB

patch

obsolete

>Subversion Revision: 231278
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 6ee4814126a5a0822d587c70546fe7d0e7af4abc..cb5cb7afc4fd000a5707e31ed5a7e107e40cf644 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-03  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set
>+        https://bugs.webkit.org/show_bug.cgi?id=185262
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix an assertion failure by setting UI process privileges in constructor of WebsiteDataStore
>+        because UI process may use the cookie API before creating a WebView.
>+
>+        * UIProcess/WebsiteData/WebsiteDataStore.cpp:
>+        (WebKit::WebsiteDataStore::WebsiteDataStore):
>+
> 2018-05-02  Jer Noble  <jer.noble@apple.com>
> 
>         Open audio/video sandbox services for minimal simulator
>diff --git a/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp b/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
>index 2aa466105b8f75c58f3d175cf6edebc4455282bd..b7545219fb90aa3ec09e14626db38b6deb05ed94 100644
>--- a/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
>+++ b/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
>@@ -48,6 +48,7 @@
> #include <WebCore/SecurityOriginData.h>
> #include <wtf/CompletionHandler.h>
> #include <wtf/CrossThreadCopier.h>
>+#include <wtf/ProcessPrivilege.h>
> #include <wtf/RunLoop.h>
> 
> #if ENABLE(NETSCAPE_PLUGIN_API)
>@@ -90,6 +91,7 @@ WebsiteDataStore::WebsiteDataStore(Configuration configuration, PAL::SessionID s
>     , m_storageManager(StorageManager::create(m_configuration.localStorageDirectory))
>     , m_queue(WorkQueue::create("com.apple.WebKit.WebsiteDataStore"))
> {
>+    WTF::setProcessPrivileges(allPrivileges());
>     maybeRegisterWithSessionIDMap();
>     platformInitialize();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 185262: 339463 | 339490 | 339511