Attachment 339495 Details for Bug 185282 – Patch

[patch] Patch

bug-185282-20180503173520.patch (text/plain), 1.89 KB, created by Megan Gardner on 2018-05-03 17:35:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2018-05-03 17:35:21 PDT

Size: 1.89 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 231336)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-05-03  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Allow Web Touch events to timeout
>+        https://bugs.webkit.org/show_bug.cgi?id=185282
>+        <rdar://problem/38728319>
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        Web Touch events currently never time out, which blocks the user from interacting with the UI Process at all.
>+        We should allow these events to time out so that the user can interact with the rest of the UI.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::handleTouchEventSynchronously):
>+
> 2018-05-03  Justin Fan  <justin_fan@apple.com>
> 
>         [WebGL] Add runtime flag for enabling ASTC support in WebGL
>Index: Source/WebKit/UIProcess/WebPageProxy.cpp
>===================================================================
>--- Source/WebKit/UIProcess/WebPageProxy.cpp	(revision 231251)
>+++ Source/WebKit/UIProcess/WebPageProxy.cpp	(working copy)
>@@ -2297,7 +2297,10 @@ void WebPageProxy::handleTouchEventSynch
> 
>     m_process->responsivenessTimer().start();
>     bool handled = false;
>-    m_process->sendSync(Messages::WebPage::TouchEventSync(event), Messages::WebPage::TouchEventSync::Reply(handled), m_pageID);
>+    bool replyReceived = m_process->sendSync(Messages::WebPage::TouchEventSync(event), Messages::WebPage::TouchEventSync::Reply(handled), m_pageID, 1_s);
>+    // If the sync request has timed out, we should consider the event handled. The Web Process is too busy to answer any questions, so the default action is also likely to have issues.
>+    if (replyReceived)
>+        handled = true;
>     didReceiveEvent(event.type(), handled);
>     m_pageClient.doneWithTouchEvent(event, handled);
>     m_process->responsivenessTimer().stop();

Actions: View | Formatted Diff | Diff

Attachments on bug 185282: 339495