Attachment 339490 Details for Bug 185262 – Patch

[patch] Patch

bug-185262-20180503171122.patch (text/plain), 1.64 KB, created by Sihui Liu on 2018-05-03 17:11:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-05-03 17:11:23 PDT

Size: 1.64 KB

patch

obsolete

>Subversion Revision: 231278
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 6ee4814126a5a0822d587c70546fe7d0e7af4abc..26638cbba632b28c305c37ca045ca85a88eec7ab 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-03  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set
>+        https://bugs.webkit.org/show_bug.cgi?id=185262
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix an assertion failure by setting UI process privileges in WKWebsiteDataStore.mm: UI 
>+        process may use the cookie API before creating a WebView.
>+
>+        * UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
>+
> 2018-05-02  Jer Noble  <jer.noble@apple.com>
> 
>         Open audio/video sandbox services for minimal simulator
>diff --git a/Source/WebKit/UIProcess/API/APIWebsiteDataStore.cpp b/Source/WebKit/UIProcess/API/APIWebsiteDataStore.cpp
>index d0472c8a71d6c812190abda7783f29f426dc3f5c..e66380ab5026dee7b0cb5aae9d171dae0babc364 100644
>--- a/Source/WebKit/UIProcess/API/APIWebsiteDataStore.cpp
>+++ b/Source/WebKit/UIProcess/API/APIWebsiteDataStore.cpp
>@@ -28,6 +28,7 @@
> 
> #include "WebKit2Initialize.h"
> #include "WebsiteDataStore.h"
>+#include <wtf/ProcessPrivilege.h>
> 
> namespace API {
> 
>@@ -66,6 +67,7 @@ WebsiteDataStore::WebsiteDataStore()
> WebsiteDataStore::WebsiteDataStore(WebKit::WebsiteDataStore::Configuration configuration, PAL::SessionID sessionID)
>     : m_websiteDataStore(WebKit::WebsiteDataStore::create(WTFMove(configuration), sessionID))
> {
>+    WTF::setProcessPrivileges(allPrivileges());
> }
> 
> WebsiteDataStore::~WebsiteDataStore()

Actions: View | Formatted Diff | Diff

Attachments on bug 185262: 339463 | 339490 | 339511