Attachment 339463 Details for Bug 185262 – Patch

[patch] Patch

bug-185262-20180503140503.patch (text/plain), 1.56 KB, created by Sihui Liu on 2018-05-03 14:05:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-05-03 14:05:04 PDT

Size: 1.56 KB

patch

obsolete

>Subversion Revision: 231278
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 6ee4814126a5a0822d587c70546fe7d0e7af4abc..26638cbba632b28c305c37ca045ca85a88eec7ab 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-03  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set
>+        https://bugs.webkit.org/show_bug.cgi?id=185262
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix an assertion failure by setting UI process privileges in WKWebsiteDataStore.mm: UI 
>+        process may use the cookie API before creating a WebView.
>+
>+        * UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
>+
> 2018-05-02  Jer Noble  <jer.noble@apple.com>
> 
>         Open audio/video sandbox services for minimal simulator
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
>index 5c6f13d87cc08a4743a55941926353c4d8420e3e..14a38fbb71ede97d97529f936b84e9905ecc6f20 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
>@@ -39,6 +39,7 @@
> #import <WebCore/URL.h>
> #import <WebKit/ServiceWorkerProcessProxy.h>
> #import <wtf/BlockPtr.h>
>+#import <wtf/ProcessPrivilege.h>
> 
> using namespace WebCore;
> 
>@@ -46,6 +47,7 @@ @implementation WKWebsiteDataStore
> 
> + (WKWebsiteDataStore *)defaultDataStore
> {
>+    WTF::setProcessPrivileges(allPrivileges());
>     return WebKit::wrapper(API::WebsiteDataStore::defaultDataStore().get());
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185262: 339463 | 339490 | 339511