Attachment 339453 Details for Bug 184840 – Patch

[patch] Patch

bug-184840-20180503133812.patch (text/plain), 3.47 KB, created by Justin Fan on 2018-05-03 13:38:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Justin Fan

Created: 2018-05-03 13:38:13 PDT

Size: 3.47 KB

patch

obsolete

>Subversion Revision: 231318
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 3d08a6be1cfb4d18a56aaa9b4364ce72b523a959..732113ab931a6c5675dc19e1fc8f2885deb2ec05 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-04-25  Justin Fan  <justin_fan@apple.com>
>+
>+        [WebGL] Add runtime flag for enabling ASTC support in WebGL
>+        https://bugs.webkit.org/show_bug.cgi?id=184840
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added runtime flag for ASTC support in WebGL, to turn on/off when extension is implemented.
>+
>+        * page/RuntimeEnabledFeatures.h:
>+        (WebCore::RuntimeEnabledFeatures::setWebGLCompressedTextureASTCSupportEnabled):
>+        (WebCore::RuntimeEnabledFeatures::webGLCompressedTextureASTCSupportEnabled const):
>+
> 2018-05-03  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Enable multiple layout roots for incremental layout.
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a48a7c759a587e4b8465847c515856b060ee8fc3..53e319952471ec5c5da99aee97487dd71ebb310e 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-04-25  Justin Fan  <justin_fan@apple.com>
>+
>+        [WebGL] Add runtime flag for enabling ASTC support in WebGL
>+        https://bugs.webkit.org/show_bug.cgi?id=184840
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added runtime flag for ASTC support in WebGL, to turn on/off when extension is implemented.
>+
>+        * Shared/WebPreferences.yaml:
>+
> 2018-05-03  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r231223 and r231288.
>diff --git a/Source/WebCore/page/RuntimeEnabledFeatures.h b/Source/WebCore/page/RuntimeEnabledFeatures.h
>index 4183297bba85bc5ab0ecbe6800d585ac92076459..7df0ac0689c46a10586a6af68215c450562c62b1 100644
>--- a/Source/WebCore/page/RuntimeEnabledFeatures.h
>+++ b/Source/WebCore/page/RuntimeEnabledFeatures.h
>@@ -252,6 +252,9 @@ public:
> 
>     void setFromOriginResponseHeaderEnabled(bool isEnabled) { m_fromOriginResponseHeaderEnabled = isEnabled; }
>     bool fromOriginResponseHeaderEnabled() const { return m_fromOriginResponseHeaderEnabled; }
>+    
>+    void setWebGLCompressedTextureASTCSupportEnabled(bool isEnabled) { m_isWebGLCompressedTextureASTCSupportEnabled = isEnabled; }
>+    bool webGLCompressedTextureASTCSupportEnabled() const { return m_isWebGLCompressedTextureASTCSupportEnabled; }
> 
>     WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures();
> 
>@@ -388,6 +391,8 @@ private:
>     bool m_isRestrictedHTTPResponseAccess { true };
> 
>     bool m_fromOriginResponseHeaderEnabled { false };
>+    
>+    bool m_isWebGLCompressedTextureASTCSupportEnabled { false };
> 
>     friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>;
> };
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 2d9430244c3c13084ad41c8be2f4a93eaf00c3ae..0e04ccd9dce6a0b16aa08b215e3d85028ba92ab1 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1251,3 +1251,11 @@ FromOriginResponseHeaderEnabled:
>     humanReadableDescription: "Support for the From-Origin Response Header"
>     category: experimental
>     webcoreBinding: RuntimeEnabledFeatures
>+
>+WebGLCompressedTextureASTCSupportEnabled:
>+  type: bool
>+  defaultValue: false
>+  humanReadableName: "ASTC Texture Support"
>+  humanReadableDescription: "Support for ASTC compressed texture formats in WebGL"
>+  category: experimental
>+  webcoreBinding: RuntimeEnabledFeatures

Actions: View | Formatted Diff | Diff

Attachments on bug 184840: 338801 | 338806 | 339125 | 339372 | 339373 | 339453