Attachment 339450 Details for Bug 185263 – Patch

[patch] Patch

bug-185263-20180503173123.patch (text/plain), 2.17 KB, created by Leo Balter on 2018-05-03 13:31:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-05-03 13:31:24 PDT

Size: 2.17 KB

patch

obsolete

>Subversion Revision: 231322
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index c83bd12098664b5f1cc358c55d30cb49e5c842b3..d798e4b06d0f8f440b708f974ea266b17fbcd539 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        cleanup modules usage for the Test262-Runner
>+        https://bugs.webkit.org/show_bug.cgi?id=185263
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/test262-runner:
>+        * Scripts/test262/Runner.pm:
>+        (processCLI):
>+
> 2018-05-03  Chris Dumez  <cdumez@apple.com>
> 
>         Load hangs if the WebProcess fails to launch
>diff --git a/Tools/Scripts/test262-runner b/Tools/Scripts/test262-runner
>index 8d3c8eb601cb1103103808f27b1b8af9f49c915b..a131bcf633e30d9765fb562425073117a98f2238 100755
>--- a/Tools/Scripts/test262-runner
>+++ b/Tools/Scripts/test262-runner
>@@ -33,7 +33,6 @@ use 5.8.8;
> 
> use FindBin;
> use Config;
>-use Encode;
> 
> BEGIN {
>     $ENV{DBIC_OVERWRITE_HELPER_METHODS_OK} = 1;
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index 8d3d19f5df3b799f3ca36f7c29bfc5406640ad5c..ea71561dbdec11667c6015275fff68ece8cae411 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -39,11 +39,15 @@ use File::Basename qw(dirname);
> use Cwd qw(abs_path);
> use FindBin;
> use Env qw(DYLD_FRAMEWORK_PATH);
>-my $Bin;
>-
> use Config;
>-use Encode;
> 
>+my $podIsAvailable;
>+if  (eval {require Pod::Usage; 1;}) {
>+    Pod::Usage->import();
>+    $podIsAvailable = 1;
>+}
>+
>+my $Bin;
> BEGIN {
>     $ENV{DBIC_OVERWRITE_HELPER_METHODS_OK} = 1;
> 
>@@ -60,8 +64,6 @@ BEGIN {
> use YAML qw(Load LoadFile Dump DumpFile Bless);
> use Parallel::ForkManager;
> use Getopt::Long qw(GetOptions);
>-use Pod::Usage;
>-use Term::ANSIColor;
> 
> # Commandline args
> my $max_process;
>@@ -135,7 +137,12 @@ sub processCLI {
>     );
> 
>     if ($help) {
>-        pod2usage(-exitstatus => 0, -verbose => 2, -input => __FILE__);
>+        if ($podIsAvailable) {
>+            pod2usage(-exitstatus => 0, -verbose => 2, -input => __FILE__);
>+        } else {
>+            print "Pod::Usage is not available to print the help options\n";
>+            exit;
>+        }
>     }
> 
>     if ($stats) {

Actions: View | Formatted Diff | Diff

Attachments on bug 185263: 339450 | 339452 | 339455 | 339457