Attachment 339447 Details for Bug 185255 – Update expectation

[patch] Update expectation

bug-185255-20180503160300.patch (text/plain), 20.15 KB, created by Chris Nardi on 2018-05-03 13:03:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Nardi

Created: 2018-05-03 13:03:01 PDT

Size: 20.15 KB

patch

obsolete

>Subversion Revision: 231306
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index bee00c2c6c681b3d725ec9f576ded3cec8bd05ff..0d0ce085a4b71e4260b95deb324c68f3322817e2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-03  Chris Nardi  <cnardi@chromium.org>
>+
>+        Remove [NoInterfaceObject] from DOMRectList
>+        https://bugs.webkit.org/show_bug.cgi?id=185255
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In https://github.com/w3c/fxtf-drafts/issues/233, [NoInterfaceObject] was removed
>+        from DOMRectList. Remove it from our implementation to match the spec, as well as
>+        Chrome and Firefox.
>+
>+        Updated web platform tests IDL test for the Geometry spec.
>+
>+        * dom/DOMRectList.idl:
>+
> 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r231253.
>diff --git a/Source/WebCore/dom/DOMRectList.idl b/Source/WebCore/dom/DOMRectList.idl
>index e611283db948667588f13e4def75cd48e5873682..52076123641607b7e3199ac34430ae96e3127f73 100644
>--- a/Source/WebCore/dom/DOMRectList.idl
>+++ b/Source/WebCore/dom/DOMRectList.idl
>@@ -25,8 +25,7 @@
> 
> [
>      ExportMacro=WEBCORE_EXPORT,
>-     ImplementationLacksVTable,
>-     NoInterfaceObject
>+     ImplementationLacksVTable
> ] interface DOMRectList {
>     readonly attribute unsigned long length;
>     getter DOMRect item(unsigned long index);
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 513f5482822a7829d61498ba2593221ca950a7bb..846a8e8d404ba8d6431d06d06625334a96898f12 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-03  Chris Nardi  <cnardi@chromium.org>
>+
>+        Remove [NoInterfaceObject] from DOMRectList
>+        https://bugs.webkit.org/show_bug.cgi?id=185255
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update Geometry IDL test from upstream and update expectations.
>+
>+        * web-platform-tests/css/geometry/interfaces-expected.txt:
>+        * web-platform-tests/css/geometry/interfaces.worker-expected.txt:
>+        * web-platform-tests/interfaces/geometry.idl:
>+
> 2018-05-02  Youenn Fablet  <youenn@apple.com>
> 
>         Rebase imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html expectation
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces-expected.txt
>index 36ccef3b755c5b5bee616b70c43b6ea391b79b61..c899a3189b84833295d754cb04f41d96606d58e2 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces-expected.txt
>@@ -18,6 +18,8 @@ PASS DOMPointReadOnly interface: attribute w
> PASS Unscopable handled correctly for w property on DOMPointReadOnly 
> PASS DOMPointReadOnly interface: operation matrixTransform(DOMMatrixInit) 
> PASS Unscopable handled correctly for matrixTransform(DOMMatrixInit) on DOMPointReadOnly 
>+PASS DOMPointReadOnly interface: operation toJSON() 
>+PASS Unscopable handled correctly for toJSON() on DOMPointReadOnly 
> PASS DOMPointReadOnly must be primary interface of new DOMPointReadOnly() 
> PASS Stringification of new DOMPointReadOnly() 
> PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "fromPoint(DOMPointInit)" with the proper type 
>@@ -28,6 +30,8 @@ PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "z
> PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "w" with the proper type 
> PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "matrixTransform(DOMMatrixInit)" with the proper type 
> PASS DOMPointReadOnly interface: calling matrixTransform(DOMMatrixInit) on new DOMPointReadOnly() with too few arguments must throw TypeError 
>+PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMPointReadOnly 
> PASS DOMPoint interface: existence and properties of interface object 
> PASS DOMPoint interface object length 
> PASS DOMPoint interface object name 
>@@ -65,6 +69,8 @@ PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "z" with t
> PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "w" with the proper type 
> PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "matrixTransform(DOMMatrixInit)" with the proper type 
> PASS DOMPointReadOnly interface: calling matrixTransform(DOMMatrixInit) on new DOMPoint() with too few arguments must throw TypeError 
>+PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMPoint 
> PASS DOMRectReadOnly interface: existence and properties of interface object 
> PASS DOMRectReadOnly interface object length 
> PASS DOMRectReadOnly interface object name 
>@@ -89,6 +95,8 @@ PASS DOMRectReadOnly interface: attribute bottom
> PASS Unscopable handled correctly for bottom property on DOMRectReadOnly 
> PASS DOMRectReadOnly interface: attribute left 
> PASS Unscopable handled correctly for left property on DOMRectReadOnly 
>+PASS DOMRectReadOnly interface: operation toJSON() 
>+PASS Unscopable handled correctly for toJSON() on DOMRectReadOnly 
> PASS DOMRectReadOnly must be primary interface of new DOMRectReadOnly() 
> PASS Stringification of new DOMRectReadOnly() 
> PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "fromRect(DOMRectInit)" with the proper type 
>@@ -101,6 +109,8 @@ PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "top
> PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "right" with the proper type 
> PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "bottom" with the proper type 
> PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "left" with the proper type 
>+PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMRectReadOnly 
> PASS DOMRect interface: existence and properties of interface object 
> PASS DOMRect interface object length 
> PASS DOMRect interface object name 
>@@ -140,6 +150,19 @@ PASS DOMRectReadOnly interface: new DOMRect() must inherit property "top" with t
> PASS DOMRectReadOnly interface: new DOMRect() must inherit property "right" with the proper type 
> PASS DOMRectReadOnly interface: new DOMRect() must inherit property "bottom" with the proper type 
> PASS DOMRectReadOnly interface: new DOMRect() must inherit property "left" with the proper type 
>+PASS DOMRectReadOnly interface: new DOMRect() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMRect 
>+PASS DOMRectList interface: existence and properties of interface object 
>+PASS DOMRectList interface object length 
>+PASS DOMRectList interface object name 
>+PASS DOMRectList interface: existence and properties of interface prototype object 
>+PASS DOMRectList interface: existence and properties of interface prototype object's "constructor" property 
>+PASS DOMRectList interface: existence and properties of interface prototype object's @@unscopables property 
>+PASS DOMRectList interface: attribute length 
>+PASS Unscopable handled correctly for length property on DOMRectList 
>+PASS DOMRectList interface: operation item(unsigned long) 
>+PASS Unscopable handled correctly for item(unsigned long) on DOMRectList 
>+PASS DOMRectList must be primary interface of [object DOMRectList] 
> PASS Stringification of [object DOMRectList] 
> PASS DOMRectList interface: [object DOMRectList] must inherit property "length" with the proper type 
> PASS DOMRectList interface: [object DOMRectList] must inherit property "item(unsigned long)" with the proper type 
>@@ -164,6 +187,8 @@ PASS DOMQuad interface: attribute p4
> PASS Unscopable handled correctly for p4 property on DOMQuad 
> PASS DOMQuad interface: operation getBounds() 
> PASS Unscopable handled correctly for getBounds() on DOMQuad 
>+PASS DOMQuad interface: operation toJSON() 
>+PASS Unscopable handled correctly for toJSON() on DOMQuad 
> PASS DOMQuad must be primary interface of new DOMQuad() 
> PASS Stringification of new DOMQuad() 
> PASS DOMQuad interface: new DOMQuad() must inherit property "fromRect(DOMRectInit)" with the proper type 
>@@ -175,6 +200,8 @@ PASS DOMQuad interface: new DOMQuad() must inherit property "p2" with the proper
> PASS DOMQuad interface: new DOMQuad() must inherit property "p3" with the proper type 
> PASS DOMQuad interface: new DOMQuad() must inherit property "p4" with the proper type 
> PASS DOMQuad interface: new DOMQuad() must inherit property "getBounds()" with the proper type 
>+PASS DOMQuad interface: new DOMQuad() must inherit property "toJSON()" with the proper type 
>+FAIL Test default toJSON operation of DOMQuad assert_true: instanceof DOMPoint expected true got false
> PASS DOMMatrixReadOnly interface: existence and properties of interface object 
> PASS DOMMatrixReadOnly interface object length 
> PASS DOMMatrixReadOnly interface object name 
>@@ -266,6 +293,8 @@ PASS Unscopable handled correctly for toFloat32Array() on DOMMatrixReadOnly
> PASS DOMMatrixReadOnly interface: operation toFloat64Array() 
> PASS Unscopable handled correctly for toFloat64Array() on DOMMatrixReadOnly 
> PASS DOMMatrixReadOnly interface: stringifier 
>+PASS DOMMatrixReadOnly interface: operation toJSON() 
>+PASS Unscopable handled correctly for toJSON() on DOMMatrixReadOnly 
> PASS DOMMatrixReadOnly must be primary interface of new DOMMatrixReadOnly() 
> PASS Stringification of new DOMMatrixReadOnly() 
> PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "fromMatrix(DOMMatrixInit)" with the proper type 
>@@ -323,6 +352,8 @@ PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property
> PASS DOMMatrixReadOnly interface: calling transformPoint(DOMPointInit) on new DOMMatrixReadOnly() with too few arguments must throw TypeError 
> PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toFloat32Array()" with the proper type 
> PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toFloat64Array()" with the proper type 
>+PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMMatrixReadOnly 
> PASS DOMMatrixReadOnly must be primary interface of DOMMatrixReadOnly.fromMatrix({is2D: false}) 
> PASS Stringification of DOMMatrixReadOnly.fromMatrix({is2D: false}) 
> PASS DOMMatrix interface: existence and properties of interface object 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces.worker-expected.txt
>index a0fd7330034742443bd2f7d3666f3fca44cc3134..81ca4b8cfe106fa13466d8b06001ba15491bc6eb 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces.worker-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces.worker-expected.txt
>@@ -18,6 +18,8 @@ PASS DOMPointReadOnly interface: attribute w
> PASS Unscopable handled correctly for w property on DOMPointReadOnly 
> PASS DOMPointReadOnly interface: operation matrixTransform(DOMMatrixInit) 
> PASS Unscopable handled correctly for matrixTransform(DOMMatrixInit) on DOMPointReadOnly 
>+PASS DOMPointReadOnly interface: operation toJSON() 
>+PASS Unscopable handled correctly for toJSON() on DOMPointReadOnly 
> PASS DOMPointReadOnly must be primary interface of new DOMPointReadOnly() 
> PASS Stringification of new DOMPointReadOnly() 
> PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "fromPoint(DOMPointInit)" with the proper type 
>@@ -28,6 +30,8 @@ PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "z
> PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "w" with the proper type 
> PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "matrixTransform(DOMMatrixInit)" with the proper type 
> PASS DOMPointReadOnly interface: calling matrixTransform(DOMMatrixInit) on new DOMPointReadOnly() with too few arguments must throw TypeError 
>+PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMPointReadOnly 
> PASS DOMPoint interface: existence and properties of interface object 
> PASS DOMPoint interface object length 
> PASS DOMPoint interface object name 
>@@ -61,6 +65,8 @@ PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "z" with t
> PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "w" with the proper type 
> PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "matrixTransform(DOMMatrixInit)" with the proper type 
> PASS DOMPointReadOnly interface: calling matrixTransform(DOMMatrixInit) on new DOMPoint() with too few arguments must throw TypeError 
>+PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMPoint 
> PASS DOMRectReadOnly interface: existence and properties of interface object 
> PASS DOMRectReadOnly interface object length 
> PASS DOMRectReadOnly interface object name 
>@@ -85,6 +91,8 @@ PASS DOMRectReadOnly interface: attribute bottom
> PASS Unscopable handled correctly for bottom property on DOMRectReadOnly 
> PASS DOMRectReadOnly interface: attribute left 
> PASS Unscopable handled correctly for left property on DOMRectReadOnly 
>+PASS DOMRectReadOnly interface: operation toJSON() 
>+PASS Unscopable handled correctly for toJSON() on DOMRectReadOnly 
> PASS DOMRectReadOnly must be primary interface of new DOMRectReadOnly() 
> PASS Stringification of new DOMRectReadOnly() 
> PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "fromRect(DOMRectInit)" with the proper type 
>@@ -97,6 +105,8 @@ PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "top
> PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "right" with the proper type 
> PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "bottom" with the proper type 
> PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "left" with the proper type 
>+PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMRectReadOnly 
> PASS DOMRect interface: existence and properties of interface object 
> PASS DOMRect interface object length 
> PASS DOMRect interface object name 
>@@ -132,6 +142,9 @@ PASS DOMRectReadOnly interface: new DOMRect() must inherit property "top" with t
> PASS DOMRectReadOnly interface: new DOMRect() must inherit property "right" with the proper type 
> PASS DOMRectReadOnly interface: new DOMRect() must inherit property "bottom" with the proper type 
> PASS DOMRectReadOnly interface: new DOMRect() must inherit property "left" with the proper type 
>+PASS DOMRectReadOnly interface: new DOMRect() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMRect 
>+PASS DOMRectList interface: existence and properties of interface object 
> PASS DOMQuad interface: existence and properties of interface object 
> PASS DOMQuad interface object length 
> PASS DOMQuad interface object name 
>@@ -152,6 +165,8 @@ PASS DOMQuad interface: attribute p4
> PASS Unscopable handled correctly for p4 property on DOMQuad 
> PASS DOMQuad interface: operation getBounds() 
> PASS Unscopable handled correctly for getBounds() on DOMQuad 
>+PASS DOMQuad interface: operation toJSON() 
>+PASS Unscopable handled correctly for toJSON() on DOMQuad 
> PASS DOMQuad must be primary interface of new DOMQuad() 
> PASS Stringification of new DOMQuad() 
> PASS DOMQuad interface: new DOMQuad() must inherit property "fromRect(DOMRectInit)" with the proper type 
>@@ -163,6 +178,8 @@ PASS DOMQuad interface: new DOMQuad() must inherit property "p2" with the proper
> PASS DOMQuad interface: new DOMQuad() must inherit property "p3" with the proper type 
> PASS DOMQuad interface: new DOMQuad() must inherit property "p4" with the proper type 
> PASS DOMQuad interface: new DOMQuad() must inherit property "getBounds()" with the proper type 
>+PASS DOMQuad interface: new DOMQuad() must inherit property "toJSON()" with the proper type 
>+FAIL Test default toJSON operation of DOMQuad assert_true: instanceof DOMPoint expected true got false
> PASS DOMMatrixReadOnly interface: existence and properties of interface object 
> PASS DOMMatrixReadOnly interface object length 
> PASS DOMMatrixReadOnly interface object name 
>@@ -254,6 +271,8 @@ PASS Unscopable handled correctly for toFloat32Array() on DOMMatrixReadOnly
> PASS DOMMatrixReadOnly interface: operation toFloat64Array() 
> PASS Unscopable handled correctly for toFloat64Array() on DOMMatrixReadOnly 
> PASS DOMMatrixReadOnly interface: member undefined 
>+PASS DOMMatrixReadOnly interface: operation toJSON() 
>+PASS Unscopable handled correctly for toJSON() on DOMMatrixReadOnly 
> PASS DOMMatrixReadOnly must be primary interface of new DOMMatrixReadOnly() 
> PASS Stringification of new DOMMatrixReadOnly() 
> PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "fromMatrix(DOMMatrixInit)" with the proper type 
>@@ -312,6 +331,8 @@ PASS DOMMatrixReadOnly interface: calling transformPoint(DOMPointInit) on new DO
> PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toFloat32Array()" with the proper type 
> PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toFloat64Array()" with the proper type 
> PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must not have property "undefined" 
>+PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toJSON()" with the proper type 
>+PASS Test default toJSON operation of DOMMatrixReadOnly 
> PASS DOMMatrixReadOnly must be primary interface of DOMMatrixReadOnly.fromMatrix({is2D: false}) 
> PASS Stringification of DOMMatrixReadOnly.fromMatrix({is2D: false}) 
> PASS DOMMatrix interface: existence and properties of interface object 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/interfaces/geometry.idl b/LayoutTests/imported/w3c/web-platform-tests/interfaces/geometry.idl
>index 556e8a5cdef19cdd9bf0a5d20bb4b5603cfacb79..be1d56b26dcb30b89d55c8e8813eca0d7ec7e515 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/interfaces/geometry.idl
>+++ b/LayoutTests/imported/w3c/web-platform-tests/interfaces/geometry.idl
>@@ -1,3 +1,7 @@
>+// GENERATED CONTENT - DO NOT EDIT
>+// Content of this file was automatically extracted from the Geometry Interfaces spec.
>+// See https://drafts.fxtf.org/geometry/
>+
> [Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
>              optional unrestricted double z = 0, optional unrestricted double w = 1),
>  Exposed=(Window,Worker),
>@@ -12,7 +16,7 @@ interface DOMPointReadOnly {
> 
>     DOMPoint matrixTransform(optional DOMMatrixInit matrix);
> 
>-    [Default] toJSON();
>+    [Default] object toJSON();
> };
> 
> [Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
>@@ -52,7 +56,7 @@ interface DOMRectReadOnly {
>     readonly attribute unrestricted double bottom;
>     readonly attribute unrestricted double left;
> 
>-    [Default] toJSON();
>+    [Default] object toJSON();
> };
> 
> [Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
>@@ -76,8 +80,6 @@ dictionary DOMRectInit {
>     unrestricted double height = 0;
> };
> 
>-[NoInterfaceObject,
>- LegacyArrayClass]
> interface DOMRectList {
>     readonly attribute unsigned long length;
>     getter DOMRect? item(unsigned long index);
>@@ -97,7 +99,7 @@ interface DOMQuad {
>     [SameObject] readonly attribute DOMPoint p4;
>     [NewObject] DOMRect getBounds();
> 
>-    [Default] toJSON();
>+    [Default] object toJSON();
> };
> 
> dictionary DOMQuadInit {
>@@ -178,7 +180,7 @@ interface DOMMatrixReadOnly {
>     [NewObject] Float64Array toFloat64Array();
> 
>     [Exposed=Window] stringifier;
>-    [Default] toJSON();
>+    [Default] object toJSON();
> };
> 
> [Constructor(optional (DOMString or sequence<unrestricted double>) init),

Actions: View | Formatted Diff | Diff

Attachments on bug 185255: 339416 | 339426 | 339428 | 339430 | 339447