Attachment 339425 Details for Bug 185259 – Patch

[patch] Patch

bug-185259-20180503103549.patch (text/plain), 1.84 KB, created by Chris Dumez on 2018-05-03 10:35:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-05-03 10:35:49 PDT

Size: 1.84 KB

patch

obsolete

>Subversion Revision: 231230
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index c2f64d2955ca45b4f31ddd73fe9d8cc31d394981..5604ad0a148124cb3922987fce089c0689d92b5e 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-03  Chris Dumez  <cdumez@apple.com>
>+
>+        REGRESSION: Layout Test http/tests/security/location-cross-origin.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=185259
>+
>+        Unreviewed, stop relying on a setImeout(100) and epect the frame navigation to have completed. Instead,
>+        use a setInterval() to poll until the cross-origin frame has navigated.
>+
>+        * http/tests/security/location-cross-origin.html:
>+
> 2018-05-02  Ms2ger  <Ms2ger@igalia.com>
> 
>         Update document-create-touch.html expectations for r231114
>diff --git a/LayoutTests/http/tests/security/location-cross-origin.html b/LayoutTests/http/tests/security/location-cross-origin.html
>index 254010f7ce15ee1b298b287f5ad604e19c4583d9..455c1574357e4d4ff3af2e30c971929832e49106 100644
>--- a/LayoutTests/http/tests/security/location-cross-origin.html
>+++ b/LayoutTests/http/tests/security/location-cross-origin.html
>@@ -60,10 +60,15 @@ onload = function() {
> 
>     // Setting 'href' cross origin should be allowed.
>     shouldNotThrow("frames[0].location.href = 'about:blank'");
>-    setTimeout(function() {
>-        shouldBeEqualToString("frames[0].location.href", "about:blank");
>-        finishJSTest();
>-    }, 100);
>+    handle = setInterval(function() {
>+        try {
>+            frames[0].location.href; // Should throw if still cross-origin.
>+
>+            shouldBeEqualToString("frames[0].location.href", "about:blank");
>+            clearInterval(handle);
>+            finishJSTest();
>+        } catch (e) { }
>+    }, 5);
> };
> </script>
> <script src="../../../resources/js-test-post.js"></script>

Actions: View | Formatted Diff | Diff

Attachments on bug 185259: 339425