Attachment 339416 Details for Bug 185255 – Patch

[patch] Patch

bug-185255-20180503122742.patch (text/plain), 4.16 KB, created by Chris Nardi on 2018-05-03 09:27:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Nardi

Created: 2018-05-03 09:27:42 PDT

Size: 4.16 KB

patch

obsolete

>Subversion Revision: 231306
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index bee00c2c6c681b3d725ec9f576ded3cec8bd05ff..0d0ce085a4b71e4260b95deb324c68f3322817e2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-03  Chris Nardi  <cnardi@chromium.org>
>+
>+        Remove [NoInterfaceObject] from DOMRectList
>+        https://bugs.webkit.org/show_bug.cgi?id=185255
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In https://github.com/w3c/fxtf-drafts/issues/233, [NoInterfaceObject] was removed
>+        from DOMRectList. Remove it from our implementation to match the spec, as well as
>+        Chrome and Firefox.
>+
>+        Updated web platform tests IDL test for the Geometry spec.
>+
>+        * dom/DOMRectList.idl:
>+
> 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r231253.
>diff --git a/Source/WebCore/dom/DOMRectList.idl b/Source/WebCore/dom/DOMRectList.idl
>index e611283db948667588f13e4def75cd48e5873682..52076123641607b7e3199ac34430ae96e3127f73 100644
>--- a/Source/WebCore/dom/DOMRectList.idl
>+++ b/Source/WebCore/dom/DOMRectList.idl
>@@ -25,8 +25,7 @@
> 
> [
>      ExportMacro=WEBCORE_EXPORT,
>-     ImplementationLacksVTable,
>-     NoInterfaceObject
>+     ImplementationLacksVTable
> ] interface DOMRectList {
>     readonly attribute unsigned long length;
>     getter DOMRect item(unsigned long index);
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 513f5482822a7829d61498ba2593221ca950a7bb..2bf6c4f1fcc5e337b4ccb116e40494a3aa81da8a 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-03  Chris Nardi  <cnardi@chromium.org>
>+
>+        Remove [NoInterfaceObject] from DOMRectList
>+        https://bugs.webkit.org/show_bug.cgi?id=185255
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update Geometry IDL from upstream web platform tests.
>+
>+        * web-platform-tests/interfaces/geometry.idl:
>+
> 2018-05-02  Youenn Fablet  <youenn@apple.com>
> 
>         Rebase imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html expectation
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/interfaces/geometry.idl b/LayoutTests/imported/w3c/web-platform-tests/interfaces/geometry.idl
>index 556e8a5cdef19cdd9bf0a5d20bb4b5603cfacb79..be1d56b26dcb30b89d55c8e8813eca0d7ec7e515 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/interfaces/geometry.idl
>+++ b/LayoutTests/imported/w3c/web-platform-tests/interfaces/geometry.idl
>@@ -1,3 +1,7 @@
>+// GENERATED CONTENT - DO NOT EDIT
>+// Content of this file was automatically extracted from the Geometry Interfaces spec.
>+// See https://drafts.fxtf.org/geometry/
>+
> [Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
>              optional unrestricted double z = 0, optional unrestricted double w = 1),
>  Exposed=(Window,Worker),
>@@ -12,7 +16,7 @@ interface DOMPointReadOnly {
> 
>     DOMPoint matrixTransform(optional DOMMatrixInit matrix);
> 
>-    [Default] toJSON();
>+    [Default] object toJSON();
> };
> 
> [Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
>@@ -52,7 +56,7 @@ interface DOMRectReadOnly {
>     readonly attribute unrestricted double bottom;
>     readonly attribute unrestricted double left;
> 
>-    [Default] toJSON();
>+    [Default] object toJSON();
> };
> 
> [Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
>@@ -76,8 +80,6 @@ dictionary DOMRectInit {
>     unrestricted double height = 0;
> };
> 
>-[NoInterfaceObject,
>- LegacyArrayClass]
> interface DOMRectList {
>     readonly attribute unsigned long length;
>     getter DOMRect? item(unsigned long index);
>@@ -97,7 +99,7 @@ interface DOMQuad {
>     [SameObject] readonly attribute DOMPoint p4;
>     [NewObject] DOMRect getBounds();
> 
>-    [Default] toJSON();
>+    [Default] object toJSON();
> };
> 
> dictionary DOMQuadInit {
>@@ -178,7 +180,7 @@ interface DOMMatrixReadOnly {
>     [NewObject] Float64Array toFloat64Array();
> 
>     [Exposed=Window] stringifier;
>-    [Default] toJSON();
>+    [Default] object toJSON();
> };
> 
> [Constructor(optional (DOMString or sequence<unrestricted double>) init),

Flags:

ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 185255: 339416 | 339426 | 339428 | 339430 | 339447