Attachment 339405 Details for Bug 185247 – Patch

[patch] Patch

bug-185247-20180503160419.patch (text/plain), 1.42 KB, created by Dominik Inführ on 2018-05-03 07:04:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dominik Inführ

Created: 2018-05-03 07:04:21 PDT

Size: 1.42 KB

patch

obsolete

>Subversion Revision: 231300
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 20a76abda0d5e0f675e3a6782c3b25dd862e5490..2be1ec82655b34ac1648cb88c45254afd572b271 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-03  Dominik Infuehr  <dinfuehr@igalia.com>
>+
>+        Invoke ensureArrayStorage for all arguments
>+        https://bugs.webkit.org/show_bug.cgi?id=185247
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        ensureArrayStorage was only invoked for first argument in each loop iteration.
>+
>+        * jsc.cpp:
>+        (functionEnsureArrayStorage):
>+
> 2018-05-02  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         Unreviewed, fix build failure in ARM, ARMv7 and MIPS
>diff --git a/Source/JavaScriptCore/jsc.cpp b/Source/JavaScriptCore/jsc.cpp
>index 90dda2da029b5ebc2eb17b29e2f73a260da4d2d3..26bed7cf968d1b682ac26d544ad4dece291d67f5 100644
>--- a/Source/JavaScriptCore/jsc.cpp
>+++ b/Source/JavaScriptCore/jsc.cpp
>@@ -2037,7 +2037,7 @@ EncodedJSValue JSC_HOST_CALL functionEnsureArrayStorage(ExecState* exec)
> {
>     VM& vm = exec->vm();
>     for (unsigned i = 0; i < exec->argumentCount(); ++i) {
>-        if (JSObject* object = jsDynamicCast<JSObject*>(vm, exec->argument(0)))
>+        if (JSObject* object = jsDynamicCast<JSObject*>(vm, exec->argument(i)))
>             object->ensureArrayStorage(vm);
>     }
>     return JSValue::encode(jsUndefined());

Actions: View | Formatted Diff | Diff

Attachments on bug 185247: 339405