Attachment 339402 Details for Bug 185072 – Patch

[patch] Patch

wk2-wtr-crossing-events.diff (text/plain), 6.30 KB, created by Carlos Garcia Campos on 2018-05-03 04:16:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2018-05-03 04:16:30 PDT

Size: 6.30 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index c5d091f1799..67a00ace24f 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK] Some event tests failing after r230817
>+        https://bugs.webkit.org/show_bug.cgi?id=185072
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove expectations for tests that are passing now.
>+
>+        * platform/gtk/TestExpectations:
>+
> 2018-05-02  Said Abou-Hallawa  <sabouhallawa@apple.com>
> 
>         Hiding then showing an <object> of type image makes the underlaying image disappear
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 25e6e57ed60..9746edbe338 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -2349,7 +2349,6 @@ webkit.org/b/157179 editing/pasteboard/drag-selected-image-to-contenteditable.ht
> webkit.org/b/157179 editing/pasteboard/drop-file-svg.html [ Failure ]
> webkit.org/b/157179 editing/pasteboard/drop-inputtext-acquires-style.html [ Failure ]
> webkit.org/b/157179 editing/pasteboard/drop-link.html [ Failure ]
>-webkit.org/b/157179 editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html [ Failure ]
> webkit.org/b/157179 editing/pasteboard/drop-text-without-selection.html [ Failure ]
> webkit.org/b/157179 editing/pasteboard/get-data-text-plain-drop.html [ Failure ]
> webkit.org/b/157179 editing/pasteboard/smart-drag-drop.html [ Failure ]
>@@ -2370,7 +2369,6 @@ webkit.org/b/157179 fast/events/drag-and-drop.html [ Failure Timeout ]
> webkit.org/b/157179 fast/events/drag-and-drop-subframe-dataTransfer.html [ Failure Timeout ]
> webkit.org/b/42194 fast/events/drag-and-drop-link.html [ Failure ]
> webkit.org/b/157179 fast/events/drag-and-drop-link-into-focused-contenteditable.html [ Failure ]
>-webkit.org/b/157179 fast/events/drag-selects-image.html [ Failure ]
> webkit.org/b/157179 fast/events/draggable-div-customdata.html [ Failure ]
> webkit.org/b/157179 fast/events/draggable-div-nodata.html [ Failure ]
> webkit.org/b/157179 fast/events/dropzone-001.html [ Failure Timeout ]
>@@ -2603,8 +2601,6 @@ webkit.org/b/58845 fast/dom/title-directionality-removeChild.html [ Failure ]
> # HTTP 204 (No Content) should be ignored
> webkit.org/b/60206 http/tests/navigation/response204.html [ Failure ]
> 
>-webkit.org/b/61630 fast/events/dropzone-005.html [ Failure ]
>-
> webkit.org/b/68278 http/tests/history/back-with-fragment-change.php [ Pass Failure ]
> 
> webkit.org/b/68512 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
>@@ -3079,8 +3075,6 @@ webkit.org/b/163972 fast/canvas/canvas-gradient-addStop-error.html [ Failure ]
> 
> webkit.org/b/163974 fast/canvas/drawImage-with-negative-source-destination.html [ Failure ]
> 
>-webkit.org/b/163976 fast/css/user-drag-none.html [ Failure ]
>-
> webkit.org/b/163977 fast/css/will-change/will-change-creates-stacking-context-inline.html [ ImageOnlyFailure ]
> webkit.org/b/163979 fast/css/will-change/will-change-creates-stacking-context.html [ ImageOnlyFailure ]
> 
>@@ -3367,10 +3361,6 @@ webkit.org/b/184778 inspector/canvas/setShaderProgramHighlighted.html [ Failure
> webkit.org/b/184779 transitions/clip-path-path-transitions.html [ Failure ]
> webkit.org/b/184779 transitions/clip-path-transitions.html [ Failure ]
> 
>-webkit.org/b/185072 fast/events/mouse-click-events.html [ Failure ]
>-webkit.org/b/185072 fast/events/context-activated-by-key-event.html [ Failure ]
>-webkit.org/b/185072 fast/events/mouse-cursor-change.html [ Failure ]
>-
> #////////////////////////////////////////////////////////////////////////////////////////
> # End of non-crashing, non-flaky tests failing
> #////////////////////////////////////////////////////////////////////////////////////////
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a7db35ff790..b1c95956904 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,24 @@
>+2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK] Some event tests failing after r230817
>+        https://bugs.webkit.org/show_bug.cgi?id=185072
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Do not send mouse move events to the WebProcess for crossing events during testing. WTR never generates crossing
>+        events and they can confuse tests.
>+
>+        Fixes: editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html
>+               fast/css/user-drag-none.html
>+               fast/events/context-activated-by-key-event.html
>+               fast/events/drag-selects-image.html
>+               fast/events/dropzone-005.html
>+               fast/events/mouse-click-events.html
>+               fast/events/mouse-cursor-change.html
>+
>+        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
>+        (webkitWebViewBaseCrossingNotifyEvent):
>+
> 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
>diff --git a/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp b/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
>index b9d6dcdc325..3b4e988a2a7 100644
>--- a/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
>+++ b/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
>@@ -893,6 +893,14 @@ static gboolean webkitWebViewBaseCrossingNotifyEvent(GtkWidget* widget, GdkEvent
>     if (priv->authenticationDialog)
>         return GDK_EVENT_PROPAGATE;
> 
>+#if ENABLE(DEVELOPER_MODE)
>+    // Do not send mouse move events to the WebProcess for crossing events during testing.
>+    // WTR never generates crossing events and they can confuse tests.
>+    // https://bugs.webkit.org/show_bug.cgi?id=185072.
>+    if (UNLIKELY(priv->pageProxy->process().processPool().configuration().fullySynchronousModeIsAllowedForTesting()))
>+        return GDK_EVENT_PROPAGATE;
>+#endif
>+
>     // In the case of crossing events, it's very important the actual coordinates the WebProcess receives, because once the mouse leaves
>     // the web view, the WebProcess won't receive more events until the mouse enters again in the web view. So, if the coordinates of the leave
>     // event are not accurate, the WebProcess might not know the mouse left the view. This can happen because of double to integer conversion,

Flags:

mcatanzaro: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185072: 339401 | 339402