Attachment 339388 Details for Bug 185237 – patch

[patch] patch

patch.txt (text/plain), 1.94 KB, created by Nan Wang on 2018-05-02 22:18:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nan Wang

Created: 2018-05-02 22:18:07 PDT

Size: 1.94 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 231294)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2018-05-02  Nan Wang  <n_wang@apple.com>
>+
>+        AX: Missing kAXSWebAccessibilityEventsEnabledNotification causes a crash
>+        https://bugs.webkit.org/show_bug.cgi?id=185237
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When libAccessibility.dylib is missing, the compiler would optimize out the global
>+        notification and lead to a crash. Fixed it by using the isNullFunction check instead,
>+        since we are sure the global notification would be there when the corresponding function 
>+        is available.
>+
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        (-[WKWebView _initializeWithConfiguration:]):
>+
> 2018-05-02  Keith Rollin  <krollin@apple.com>
> 
>         Add facility for tracking times and results of page and resource loading
>Index: Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	(revision 231292)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	(working copy)
>@@ -694,8 +694,9 @@     // We are in the View's initializati
> #endif
> 
> #if ENABLE(ACCESSIBILITY_EVENTS)
>-    const auto* notificationPtr = &kAXSWebAccessibilityEventsEnabledNotification;
>-    if (notificationPtr)
>+    // Check _AXSWebAccessibilityEventsEnabled here to avoid compiler optimizing
>+    // out the null check of kAXSWebAccessibilityEventsEnabledNotification.
>+    if (!isNullFunctionPointer(_AXSWebAccessibilityEventsEnabled))
>         CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(), (__bridge const void *)(self), accessibilityEventsEnabledChangedCallback, kAXSWebAccessibilityEventsEnabledNotification, 0, CFNotificationSuspensionBehaviorDeliverImmediately);
>     [self _updateAccessibilityEventsEnabled];
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 185237: 339388