Attachment 339365 Details for Bug 185227 – Removes the code

[patch] Removes the code

bug-185227-20180502165917.patch (text/plain), 1.38 KB, created by Ryosuke Niwa on 2018-05-02 16:59:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-05-02 16:59:17 PDT

Size: 1.38 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 231280)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-05-02  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        Remove superfluous check for a null attribute value check in Element::removeAttributeInternal
>+        https://bugs.webkit.org/show_bug.cgi?id=185227
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Removed the check. The attribute value string can never be null.
>+
>+        * dom/Element.cpp:
>+        (WebCore::Element::removeAttributeInternal):
>+
> 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
> 
>         Can't copy and paste URLs that have no title into Mail (macOS)
>Index: Source/WebCore/dom/Element.cpp
>===================================================================
>--- Source/WebCore/dom/Element.cpp	(revision 231266)
>+++ Source/WebCore/dom/Element.cpp	(working copy)
>@@ -2363,9 +2363,8 @@ void Element::removeAttributeInternal(un
>         return;
>     }
> 
>-    if (!valueBeingRemoved.isNull())
>-        willModifyAttribute(name, valueBeingRemoved, nullAtom());
>-
>+    ASSERT(!valueBeingRemoved.isNull());
>+    willModifyAttribute(name, valueBeingRemoved, nullAtom());
>     {
>         Style::AttributeChangeInvalidation styleInvalidation(*this, name, valueBeingRemoved, nullAtom());
>         elementData.removeAttribute(index);

Flags:

cdumez: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185227: 339365