WebKit Bugzilla
Attachment 339364 Details for
Bug 185216
: Hiding then showing an <object> of type image makes the underlaying image disappear
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185216-20180502165838.patch (text/plain), 4.30 KB, created by
Said Abou-Hallawa
on 2018-05-02 16:58:38 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Said Abou-Hallawa
Created:
2018-05-02 16:58:38 PDT
Size:
4.30 KB
patch
obsolete
>Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 231272) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,22 @@ >+2018-05-02 Said Abou-Hallawa <sabouhallawa@apple.com> >+ >+ Hiding then showing an <object> of type image makes the underlaying image disappear >+ https://bugs.webkit.org/show_bug.cgi?id=185216 >+ <rdar://problem/39055630> >+ >+ Reviewed by Youenn Fablet. >+ >+ Ensure the HTMLPlugInImageElement updates the RenderImageResource of its >+ RenderImage with the CachedImage of its ImageLoader when the RenderImage >+ is recreated. >+ >+ Test: fast/images/object-image-hide-show.html >+ >+ * html/HTMLPlugInImageElement.cpp: >+ (WebCore::HTMLPlugInImageElement::didAttachRenderers): >+ This is very similar to what we do in HTMLImageElement::didAttachRenderers(). >+ >+ > 2018-05-01 Ryosuke Niwa <rniwa@webkit.org> > > REGRESSION(r225868): Release assert when removing an SVGUseElement from Document::m_svgUseElements >Index: Source/WebCore/html/HTMLPlugInImageElement.cpp >=================================================================== >--- Source/WebCore/html/HTMLPlugInImageElement.cpp (revision 230959) >+++ Source/WebCore/html/HTMLPlugInImageElement.cpp (working copy) >@@ -229,6 +229,13 @@ void HTMLPlugInImageElement::didAttachRe > m_needsWidgetUpdate = true; > scheduleUpdateForAfterStyleResolution(); > >+ // Update the RenderImageResource of the associated RenderImage. >+ if (m_imageLoader && is<RenderImage>(renderer())) { >+ auto& renderImageResource = downcast<RenderImage>(*renderer()).imageResource(); >+ if (!renderImageResource.cachedImage()) >+ renderImageResource.setCachedImage(m_imageLoader->image()); >+ } >+ > HTMLPlugInElement::didAttachRenderers(); > } > >Index: LayoutTests/ChangeLog >=================================================================== >--- LayoutTests/ChangeLog (revision 230959) >+++ LayoutTests/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2018-05-02 Said Abou-Hallawa <sabouhallawa@apple.com> >+ >+ Hiding then showing an <object> of type image makes the underlaying image disappear >+ https://bugs.webkit.org/show_bug.cgi?id=185216 >+ <rdar://problem/39055630> >+ >+ Reviewed by Youenn Fablet. >+ >+ * fast/images/object-image-hide-show-expected.html: Added. >+ * fast/images/object-image-hide-show.html: Added. >+ > 2018-04-23 Daniel Bates <dabates@apple.com> > > Implement Same-Site cookies >Index: LayoutTests/fast/images/object-image-hide-show-expected.html >=================================================================== >--- LayoutTests/fast/images/object-image-hide-show-expected.html (nonexistent) >+++ LayoutTests/fast/images/object-image-hide-show-expected.html (working copy) >@@ -0,0 +1,10 @@ >+<style> >+ div { >+ width: 100px; >+ height: 100px; >+ background-color: lime; >+ } >+</style> >+<body> >+ <div></div> >+</body> >Index: LayoutTests/fast/images/object-image-hide-show.html >=================================================================== >--- LayoutTests/fast/images/object-image-hide-show.html (nonexistent) >+++ LayoutTests/fast/images/object-image-hide-show.html (working copy) >@@ -0,0 +1,33 @@ >+<style> >+ object { >+ width: 100px; >+ height: 100px; >+ } >+</style> >+<body> >+ <object data="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAADElEQVQIHWNg+M8AAAICAQDpLOrTAAAAAElFTkSuQmCC" type="image/png" /> >+ <script> >+ function toggleVisiblity(element, after) { >+ return new Promise((resolve) => { >+ setTimeout(() => { >+ if (element.style.display === "none") >+ element.style.display = "block"; >+ else >+ element.style.display = "none"; >+ resolve(); >+ }, after); >+ }); >+ } >+ >+ if (window.testRunner) >+ testRunner.waitUntilDone(); >+ >+ var element = document.querySelector("object"); >+ toggleVisiblity(element, 50).then(() => { >+ return toggleVisiblity(element, 50); >+ }).then(() => { >+ if (window.testRunner) >+ testRunner.notifyDone(); >+ }); >+ </script> >+</body>
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185216
:
339339
|
339343
|
339361
| 339364