Attachment 339333 Details for Bug 185214 – Patch

[patch] Patch

bug-185214-20180502135651.patch (text/plain), 1.67 KB, created by Jeremy Jones on 2018-05-02 13:56:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-05-02 13:56:51 PDT

Size: 1.67 KB

patch

obsolete

>Subversion Revision: 231157
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 94ad2070a4ea348dc42026f18b777d87595753d6..92aaa2bc26fe9e32af7cef96b69981dbf542d6a1 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-05-02  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Dismissed video keeps playing full screen when switching back to safari
>+        https://bugs.webkit.org/show_bug.cgi?id=185214
>+        rdar://problem/39623312
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        Restore user gesture requirement on exit fullscreen if it was initially required.
>+
>+        This prevents pages from repeatedly going back into fullscreen after the user has
>+        exited fullscreen.
>+
>+        * html/HTMLMediaElement.cpp:
>+        (WebCore::HTMLMediaElement::exitFullscreen):
>+
> 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
>diff --git a/Source/WebCore/html/HTMLMediaElement.cpp b/Source/WebCore/html/HTMLMediaElement.cpp
>index 521fca2e33ebfcbda781e313813fb9d241de1ca5..61cf4925e4484eb4e66672871bf9c609068da037 100644
>--- a/Source/WebCore/html/HTMLMediaElement.cpp
>+++ b/Source/WebCore/html/HTMLMediaElement.cpp
>@@ -5885,6 +5885,11 @@ void HTMLMediaElement::exitFullscreen()
> {
>     INFO_LOG(LOGIDENTIFIER);
> 
>+#if PLATFORM(IOS)
>+    if (document.settings().videoPlaybackRequiresUserGesture() || document.settings().audioPlaybackRequiresUserGesture())
>+#endif
>+        m_mediaSession->addBehaviorRestriction(MediaElementSession::RequireUserGestureForFullscreen);
>+
>     m_waitingToEnterFullscreen = false;
> 
> #if ENABLE(FULLSCREEN_API)

Actions: View | Formatted Diff | Diff

Attachments on bug 185214: 339333 | 339345 | 339356 | 339420 | 339427 | 339438 | 339460 | 339747 | 339752 | 339759 | 339976 | 339988 | 339992 | 340002 | 340012 | 340013 | 340037 | 340195 | 340229 | 340236 | 341277 | 341284 | 341285 | 341287 | 341292 | 341826 | 341833 | 341843