Attachment 339323 Details for Bug 184469 – Patch for landing

[patch] Patch for landing

bug-184469-20180502121850.patch (text/plain), 2.97 KB, created by youenn fablet on 2018-05-02 12:18:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-02 12:18:50 PDT

Size: 2.97 KB

patch

obsolete

>Subversion Revision: 231252
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 666eb14aeba108a7bdb71972224e5598a3f43fec..f3606b9745a7ef82b12c08df3cf81b4a7ed8bc91 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-02  Youenn Fablet  <youenn@apple.com>
>+
>+        Layout Test http/wpt/service-workers/header-filtering.https.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=184469
>+        <rdar://problem/39428226>
>+
>+        Reviewed by Chris Dumez.
>+
>+        Ensure that the message posted for the loading of the initial iframe is actually received before doing further tests.
>+
>+        * http/wpt/service-workers/header-filtering.https.html:
>+        * platform/mac-wk2/TestExpectations:
>+
> 2018-05-02  Chris Dumez  <cdumez@apple.com>
> 
>         document.open() event listener removal is not immediate
>diff --git a/LayoutTests/http/wpt/service-workers/header-filtering.https.html b/LayoutTests/http/wpt/service-workers/header-filtering.https.html
>index e6b39bde92d0c56ddefa73d4b473e60d23075142..e844f90db854027ef350ad789e549d214be73f1e 100644
>--- a/LayoutTests/http/wpt/service-workers/header-filtering.https.html
>+++ b/LayoutTests/http/wpt/service-workers/header-filtering.https.html
>@@ -40,24 +40,31 @@ async function registerServiceWorker(scope)
>     });
> }
> 
>+var processMessage;
> promise_test(async (test) => {
>     registration = await registerServiceWorker(scope);
>     registration.active.postMessage("ready?");
>+
>+    navigator.serviceWorker.onmessage = (event) => {
>+        processMessage(event.data);
>+    };
>+
>     return new Promise((resolve) => {
>-        navigator.serviceWorker.onmessage = (event) => {
>+        processMessage = (data) => {
>             assert_equals(event.data, "ready");
>-            navigator.serviceWorker.onmessage = undefined;
>             resolve();
>-        };
>+        }
>     });
> }, "Prepare tests: setup worker and register the client");
> 
>-var processMessage;
> promise_test(async (test) => {
>+    const promise = new Promise((resolve) => {
>+        processMessage = (data) => {
>+            resolve(data);
>+        };
>+    });
>     frame = await withFrame(scope + "/header-filtering-iframe.html");
>-    navigator.serviceWorker.onmessage = (event) => {
>-        processMessage(event.data);
>-    };
>+    await promise;
> }, "Prepare tests: Add a frame controlled by service worker");
> 
> promise_test(async (test) => {
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index 09a103e66719076f5a7e5ed5b4721be33c7a1da8..635750e4f19c9157c7eb21ab11b77ad6b4fc0226 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -885,4 +885,3 @@ webkit.org/b/184245 http/tests/workers/service/service-worker-cache-api.https.ht
> 
> webkit.org/b/177380 http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure ]
> 
>-webkit.org/b/184469 http/wpt/service-workers/header-filtering.https.html [ Pass Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 184469: 339015 | 339323 | 340709