Attachment 339300 Details for Bug 185196 – Patch

[patch] Patch

bug-185196-20180502154527.patch (text/plain), 1.94 KB, created by Dominik Inführ on 2018-05-02 06:45:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dominik Inführ

Created: 2018-05-02 06:45:28 PDT

Size: 1.94 KB

patch

obsolete

>Subversion Revision: 231230
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 1d180d561e85019c0caa3b5b346c49a2be5f71fb..90e84ff733f063071f6ab17e4a4cd33fd528f322 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-02  Dominik Infuehr  <dinfuehr@igalia.com>
>+
>+        [ARM] Implement and16 and store16 for MacroAssemblerARMv7
>+        https://bugs.webkit.org/show_bug.cgi?id=185196
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This implements and16 and store16 for MacroAssemblerARMv7 such that JSC builds again.
>+
>+        * assembler/MacroAssemblerARMv7.h:
>+        (JSC::MacroAssemblerARMv7::and16):
>+        (JSC::MacroAssemblerARMv7::store16):
>+
> 2018-05-02  Robin Morisset  <rmorisset@apple.com>
> 
>         emitCodeToGetArgumentsArrayLength should not crash on PhantomNewArrayWithSpread
>diff --git a/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h b/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h
>index cd104590c499f1d9342322e4239c572aaeaf6e4c..81d4f7ef2685d34e3d0ed9e9de8f2b1ba437a122 100644
>--- a/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h
>+++ b/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h
>@@ -267,6 +267,12 @@ public:
>         m_assembler.str(dataTempRegister, addressTempRegister, ARMThumbImmediate::makeUInt12(4));
>     }
> 
>+    void and16(Address src, RegisterID dest)
>+    {
>+        load16(src, dataTempRegister);
>+        and32(dataTempRegister, dest);
>+    }
>+
>     void and32(RegisterID op1, RegisterID op2, RegisterID dest)
>     {
>         m_assembler.ARM_and(dest, op1, op2);
>@@ -868,7 +874,12 @@ public:
>         move(imm8, dataTempRegister);
>         store8(dataTempRegister, address);
>     }
>-    
>+
>+    void store16(RegisterID src, ImplicitAddress address)
>+    {
>+        store16(src, setupArmAddress(address));
>+    }
>+
>     void store16(RegisterID src, BaseIndex address)
>     {
>         store16(src, setupArmAddress(address));

Actions: View | Formatted Diff | Diff

Attachments on bug 185196: 339300