Attachment 339237 Details for Bug 183097 – Patch

[patch] Patch

patch.txt (text/plain), 3.63 KB, created by Nikita Vasilyev on 2018-05-01 16:11:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-05-01 16:11:42 PDT

Size: 3.63 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b462072e047..cfb7267ba51 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-03-16  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: Newly added unsupported properties sometimes don't have warnings
>+        https://bugs.webkit.org/show_bug.cgi?id=183097
>+        <rdar://problem/37843816>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update status of properties warnings every time focus moves.
>+
>+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
>+        (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
>+        (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyFocusMoved):
>+        (WI.SpreadsheetCSSStyleDeclarationEditor.prototype._propertiesChanged):
>+        (WI.SpreadsheetCSSStyleDeclarationEditor.prototype._updatePropertiesStatus):
>+        * UserInterface/Views/SpreadsheetStyleProperty.js:
>+        (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
>+
> 2018-04-26  Jer Noble  <jer.noble@apple.com>
> 
>         Unreviewed build fix; fix WebInspectorUI copy resources step after r231063.
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
>index 1eb022b1579..c9e1fc31bfa 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
>@@ -232,6 +232,11 @@ WI.SpreadsheetCSSStyleDeclarationEditor = class SpreadsheetCSSStyleDeclarationEd
> 
>     spreadsheetStylePropertyFocusMoved(propertyView, {direction, willRemoveProperty})
>     {
>+        this._updatePropertiesStatus();
>+
>+        if (!direction)
>+            return;
>+
>         let movedFromIndex = this._propertyViews.indexOf(propertyView);
>         console.assert(movedFromIndex !== -1, "Property doesn't exist, focusing on a selector as a fallback.");
>         if (movedFromIndex === -1) {
>@@ -348,13 +353,18 @@ WI.SpreadsheetCSSStyleDeclarationEditor = class SpreadsheetCSSStyleDeclarationEd
> 
>     _propertiesChanged(event)
>     {
>-        if (this.editing && isNaN(this._pendingAddBlankPropertyIndexOffset)) {
>-            for (let propertyView of this._propertyViews)
>-                propertyView.updateStatus();
>-        } else
>+        if (this.editing && isNaN(this._pendingAddBlankPropertyIndexOffset))
>+            this._updatePropertiesStatus();
>+        else
>             this.needsLayout();
>     }
> 
>+    _updatePropertiesStatus()
>+    {
>+        for (let propertyView of this._propertyViews)
>+            propertyView.updateStatus();
>+    }
>+
>     _updateStyleLock()
>     {
>         this.style.locked = this._focused || this._inlineSwatchActive;
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>index 8667db2a4b9..74f15e125b4 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>@@ -298,6 +298,9 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
> 
>         if (textField === this._valueTextField)
>             this._renderValue(this._valueElement.textContent);
>+
>+        if (typeof this._delegate.spreadsheetStylePropertyFocusMoved === "function")
>+            this._delegate.spreadsheetStylePropertyFocusMoved(this, {direction: null});
>     }
> 
>     spreadsheetTextFieldDidBackspace(textField)

Actions: View | Formatted Diff | Diff

Attachments on bug 183097: 334553 | 335965 | 339237 | 339250