Attachment 339210 Details for Bug 185169 – Patch

[patch] Patch

bug-185169-20180501215311.patch (text/plain), 1.87 KB, created by GSkachkov on 2018-05-01 11:53:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: GSkachkov

Created: 2018-05-01 11:53:13 PDT

Size: 1.87 KB

patch

obsolete

>Subversion Revision: 231201
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2a5ab73430be9982cec3adf5efbe9e40c45dd816..1defcc41248f943eef9c714e430877281cb723d6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
>+
>+        Fix build error after r339098
>+        https://bugs.webkit.org/show_bug.cgi?id=185169
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Comment ASSERT_NOT_REACHED to prevent compile error 
>+        in iOS Simulator debug build
>+
>+        * bindings/js/JSDOMWindowBase.cpp:
>+        (WebCore::JSDOMWindowBase::compileStreaming):
>+        (WebCore::JSDOMWindowBase::instantiateStreaming):
>+
> 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
> 
>         WebAssembly: add support for stream APIs - JavaScript API
>diff --git a/Source/WebCore/bindings/js/JSDOMWindowBase.cpp b/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
>index 8f409756d466250f3db27a2fb1d9373fe74882d7..53785dde508111666534f14854905ebf94d83365 100644
>--- a/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
>+++ b/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
>@@ -493,11 +493,15 @@ void JSDOMWindowBase::instantiateStreaming(JSC::JSGlobalObject* globalObject, JS
> #else
> void JSDOMWindowBase::compileStreaming(JSC::JSGlobalObject*, JSC::ExecState*, JSC::JSPromiseDeferred*, JSC::JSValue)
> {
>-    ASSERT_NOT_REACHED();
>+    // We would have really useful assertions here if it wasn't for the compiler's
>+    // insistence on attribute noreturn.
>+    // ASSERT_NOT_REACHED();
> }
> void JSDOMWindowBase::instantiateStreaming(JSC::JSGlobalObject*, JSC::ExecState*, JSC::JSPromiseDeferred*, JSC::JSValue, JSC::JSObject*)
> {
>-    ASSERT_NOT_REACHED();
>+    // We would have really useful assertions here if it wasn't for the compiler's
>+    // insistence on attribute noreturn.
>+    // ASSERT_NOT_REACHED();
> }
> #endif
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185169: 339210 | 339219 | 339220