Attachment 339200 Details for Bug 185165 – Patch

[patch] Patch

bug-185165-20180501110459.patch (text/plain), 2.91 KB, created by Michael Catanzaro on 2018-05-01 09:05:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2018-05-01 09:05:00 PDT

Size: 2.91 KB

patch

obsolete

>Subversion Revision: 231150
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 62a034011e0aaad90bb5a9a5db1dac88084304ff..38cf022a34e6db98debcd8ba16572e00bb9c6696 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-01  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        WebKit should send fake macOS user agent to docs.google.com
>+        https://bugs.webkit.org/show_bug.cgi?id=185165
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/UserAgentQuirks.cpp:
>+        (WebCore::urlRequiresMacintoshPlatform):
>+        (WebCore::urlRequiresLinuxDesktopPlatform):
>+
> 2018-04-29  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Implement Display::Box functions
>diff --git a/Source/WebCore/platform/UserAgentQuirks.cpp b/Source/WebCore/platform/UserAgentQuirks.cpp
>index e347426a9c138198444d7eca1f39bc837ed2cf71..c7d9b8ebb8e20235cdce9c61967c022237d80678 100644
>--- a/Source/WebCore/platform/UserAgentQuirks.cpp
>+++ b/Source/WebCore/platform/UserAgentQuirks.cpp
>@@ -101,12 +101,18 @@ static bool urlRequiresMacintoshPlatform(const URL& url)
>         return true;
>     }
> 
>+    // Google Docs shows a scary unsupported browser warning with WebKitGTK+'s
>+    // standard user agent.
>+    if (domain == "docs.google.com")
>+        return true;
>+
>     return false;
> }
> 
> static bool urlRequiresLinuxDesktopPlatform(const URL& url)
> {
>-    return isGoogle(url);
>+    // docs.google.com requires the macOS platform quirk.
>+    return isGoogle(url) && url.host() != "docs.google.com";
> }
> 
> UserAgentQuirks UserAgentQuirks::quirksForURL(const URL& url)
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 5f79440757d43bbc2a53367644569ddff278741a..f16626457802d820690e8a9c4dc9f03c7cc6a70b 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-01  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        WebKit should send fake macOS user agent to docs.google.com
>+        https://bugs.webkit.org/show_bug.cgi?id=185165
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
>+        (TestWebKitAPI::TEST):
>+
> 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
> 
>         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
>diff --git a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>index 2a1769e3f9787a3025d185479eab5e8a96874889..bb335d4b719ba236f3c2893b5e25f3741d5448ae 100644
>--- a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>@@ -93,6 +93,7 @@ TEST(UserAgentTest, Quirks)
>     assertUserAgentForURLHasMacPlatformQuirk("http://www.whatsapp.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://web.whatsapp.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://outlook.live.com/");
>+    assertUserAgentForURLHasMacPlatformQuirk("http://docs.google.com/");
> }
> 
> } // namespace TestWebKitAPI

Flags:

cgarcia: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 185165: 339200