Attachment 339177 Details for Bug 185157 – Patch

[patch] Patch

bug-185157-20180430202601.patch (text/plain), 1.95 KB, created by Chris Dumez on 2018-04-30 20:26:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-04-30 20:26:01 PDT

Size: 1.95 KB

patch

obsolete

>Subversion Revision: 231192
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index cba905e6179e4a78f79a07354fd7a9e518740329..2838472eb10ea27e74c8ddeaac58b42f6703e589 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-04-30  Chris Dumez  <cdumez@apple.com>
>+
>+        [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
>+        https://bugs.webkit.org/show_bug.cgi?id=185157
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
>+        common configuration and should therefore be the configuration we test by default.
>+
>+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
>+        (WTR::InjectedBundlePage::decidePolicyForResponse):
>+
> 2018-04-30  Mark Lam  <mark.lam@apple.com>
> 
>         Apply PtrTags to the MetaAllocator and friends.
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp b/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
>index 05554186ebe0c29ff5b6e16e3266dcca9120cbbc..bb3946ccc0654517c86cf95581ad52dc750035c6 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
>+++ b/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
>@@ -1387,11 +1387,7 @@ WKBundlePagePolicyAction InjectedBundlePage::decidePolicyForResponse(WKBundlePag
>         InjectedBundle::singleton().outputText(stringBuilder.toString());
>     }
> 
>-    if (injectedBundle.testRunner() && injectedBundle.testRunner()->shouldDecideResponsePolicyAfterDelay())
>-        return WKBundlePagePolicyActionPassThrough;
>-
>-    WKRetainPtr<WKStringRef> mimeType = adoptWK(WKURLResponseCopyMIMEType(response));
>-    return WKBundlePageCanShowMIMEType(page, mimeType.get()) ? WKBundlePagePolicyActionUse : WKBundlePagePolicyActionPassThrough;
>+    return WKBundlePagePolicyActionPassThrough;
> }
> 
> void InjectedBundlePage::unableToImplementPolicy(WKBundlePageRef, WKBundleFrameRef, WKErrorRef, WKTypeRef*)

Actions: View | Formatted Diff | Diff

Attachments on bug 185157: 339177