Attachment 339136 Details for Bug 185029 – Patch

[patch] Patch

bug-185029-20180430123947.patch (text/plain), 3.01 KB, created by Jer Noble on 2018-04-30 12:39:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-04-30 12:39:48 PDT

Size: 3.01 KB

patch

obsolete

>Subversion Revision: 231157
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 94ad2070a4ea348dc42026f18b777d87595753d6..9457f031d2a2a892c20d2b1d665dcd26850af442 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-04-30  Jer Noble  <jer.noble@apple.com>
>+
>+        <img src=mp4> does not display on ios despite Accept: video/* advertisement
>+        https://bugs.webkit.org/show_bug.cgi?id=185029
>+        <rdar://problem/39771989>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Returning "NO" from resourceLoader:shouldWaitForLoadingOfResource: signals that the load failed,
>+        even if the resource request is successfully fulfilled prior to the return. Always return YES in
>+        the case that loading succeeded.
>+
>+        * platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
>+        (-[WebCoreSharedBufferResourceLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
>+
> 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
>diff --git a/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm b/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm
>index a45202ea94e836b7f2c87a6edbfa7df53eef8254..6e53a1960393866827adaeb41ed482aaa85abcca 100644
>--- a/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm
>+++ b/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm
>@@ -203,7 +203,7 @@ - (BOOL)resourceLoader:(AVAssetResourceLoader *)resourceLoader shouldWaitForLoad
>     if ([self canFulfillRequest:loadingRequest]) {
>         [self fulfillRequest:loadingRequest];
>         if (loadingRequest.finished)
>-            return NO;
>+            return YES;
>     }
> 
>     [self enqueueRequest:loadingRequest];
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 7534cf5d270ee016dc7368256835e16b67ca1c06..ce3c213ae8797ca27cf7559340c42e48240b8e74 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-04-30  Jer Noble  <jer.noble@apple.com>
>+
>+        <img src=mp4> does not display on ios despite Accept: video/* advertisement
>+        https://bugs.webkit.org/show_bug.cgi?id=185029
>+        <rdar://problem/39771989>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/ios/TestExpectations:
>+
> 2018-04-28  Simon Fraser  <simon.fraser@apple.com>
> 
>         Fix color-filter to apply to SVG colors
>diff --git a/LayoutTests/platform/ios/TestExpectations b/LayoutTests/platform/ios/TestExpectations
>index f2b6825cf22cb5e210065203a2f937217211a534..230d15dd7674ce44e702cbe07066649e8737234d 100644
>--- a/LayoutTests/platform/ios/TestExpectations
>+++ b/LayoutTests/platform/ios/TestExpectations
>@@ -1110,10 +1110,6 @@ fast/viewport/ios/viewport-fit-cover.html [ Pass ]
> fast/viewport/ios/viewport-fit-auto.html [ Pass ]
> fast/css/variables/env/ios [ Pass ]
> 
>-# This test relies on APIs not available on iOS
>-fast/images/animated-image-mp4.html [ Skip ]
>-
>-
> ###
> # Known failures
> ##

Actions: View | Formatted Diff | Diff

Attachments on bug 185029: 339136