WebKit Bugzilla
Attachment 339116 Details for
Bug 185134
: Fix bad use of RunLoop::main().dispatch() in MessagePort::dispatchMessages()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185134-20180430094541.patch (text/plain), 1.78 KB, created by
Chris Dumez
on 2018-04-30 09:45:42 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Chris Dumez
Created:
2018-04-30 09:45:42 PDT
Size:
1.78 KB
patch
obsolete
>Subversion Revision: 231156 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 94ad2070a4ea348dc42026f18b777d87595753d6..7cd11edcf3f5f151bae2587de6b34d2c56e7e8eb 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,17 @@ >+2018-04-30 Chris Dumez <cdumez@apple.com> >+ >+ Fix bad use of RunLoop::main().dispatch() in MessagePort::dispatchMessages() >+ https://bugs.webkit.org/show_bug.cgi?id=185134 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fix bad use of RunLoop::main().dispatch() in MessagePort::dispatchMessages(). This code runs on iOS WebKitLegacy >+ and it is therefore unsafe to use RunLoop::main() here. We want to use callOnMainThread() instead to run code on >+ the WebThread. >+ >+ * dom/MessagePort.cpp: >+ (WebCore::MessagePort::dispatchMessages): >+ > 2018-04-30 Michael Catanzaro <mcatanzaro@igalia.com> > > [GTK] Webkit should spoof as Safari on a Mac when on Chase.com >diff --git a/Source/WebCore/dom/MessagePort.cpp b/Source/WebCore/dom/MessagePort.cpp >index cf2897664cc051e6e3f1e02334ac8613fe573896..6f7fd36be3de21fa66284102af6c5607e4b070d1 100644 >--- a/Source/WebCore/dom/MessagePort.cpp >+++ b/Source/WebCore/dom/MessagePort.cpp >@@ -284,7 +284,7 @@ void MessagePort::dispatchMessages() > } > workerThread->runLoop().postTaskForMode([innerHandler = WTFMove(innerHandler), messages = WTFMove(messages), completionCallback = WTFMove(completionCallback)](auto&) mutable { > innerHandler(WTFMove(messages)); >- RunLoop::main().dispatch([completionCallback = WTFMove(completionCallback)] { >+ callOnMainThread([completionCallback = WTFMove(completionCallback)] { > completionCallback(); > }); > }, WorkerRunLoop::defaultMode());
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185134
: 339116