Attachment 339113 Details for Bug 185125 – Patch

[patch] Patch

bug-185125-20180430093049.patch (text/plain), 2.03 KB, created by dewei_zhu on 2018-04-30 09:30:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: dewei_zhu

Created: 2018-04-30 09:30:49 PDT

Size: 2.03 KB

patch

obsolete

>Subversion Revision: 231156
>diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
>index b399bcb18c52f1bd37319eabc85e853c23806c78..cfc7662f58c9a89a34fe7525350cea638aa3aaf7 100644
>--- a/Websites/perf.webkit.org/ChangeLog
>+++ b/Websites/perf.webkit.org/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-04-30  Dewei Zhu  <dewei_zhu@apple.com>
>+
>+        REGRESSION(r230960): Browser tests under TimeSeriesChart fetchMeasurementSets all fail
>+        https://bugs.webkit.org/show_bug.cgi?id=185125
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Only import PrivilegedAPI when it is used.
>+
>+        * unit-tests/resources/mock-remote-api.js:
>+        (MockRemoteAPI.inject): Delay PrivilegedAPI import until it is used.
>+
> 2018-04-26  Dewei Zhu  <dewei_zhu@apple.com>
> 
>         Extend create-analysis-test API to be able to create with confirming test group.
>diff --git a/Websites/perf.webkit.org/unit-tests/resources/mock-remote-api.js b/Websites/perf.webkit.org/unit-tests/resources/mock-remote-api.js
>index 6bc10fb355605e5a1e7727f7d14212b5c4118b19..f130ee00cf8f1fa563eccabfad23f4d73dfeb40c 100644
>--- a/Websites/perf.webkit.org/unit-tests/resources/mock-remote-api.js
>+++ b/Websites/perf.webkit.org/unit-tests/resources/mock-remote-api.js
>@@ -1,6 +1,3 @@
>-const BrowserPrivilegedAPI = require('../../public/v3/privileged-api.js').PrivilegedAPI;
>-const NodePrivilegedAPI = require('../../tools/js/privileged-api').PrivilegedAPI;
>-
> var MockRemoteAPI = {
>     url: function (path)
>     {
>@@ -66,7 +63,8 @@ var MockRemoteAPI = {
>         let originalRemoteAPI = global.RemoteAPI;
>         let originalPrivilegedAPI = global.PrivilegedAPI;
>         const useNodePrivilegedAPI = privilegedAPIType === 'node';
>-        const PrivilegedAPI = useNodePrivilegedAPI ? NodePrivilegedAPI: BrowserPrivilegedAPI;
>+        const PrivilegedAPI = useNodePrivilegedAPI ?
>+            require('../../tools/js/privileged-api').PrivilegedAPI : require('../../public/v3/privileged-api.js').PrivilegedAPI;
> 
>         beforeEach(() => {
>             MockRemoteAPI.reset(urlPrefix);

Actions: View | Formatted Diff | Diff

Attachments on bug 185125: 339113 | 339132 | 339134