Attachment 339099 Details for Bug 185103 – Patch

[patch] Patch

bug-185103-20180429165445.patch (text/plain), 3.40 KB, created by Michael Catanzaro on 2018-04-29 14:54:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2018-04-29 14:54:45 PDT

Size: 3.40 KB

patch

obsolete

>Subversion Revision: 231150
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 62a034011e0aaad90bb5a9a5db1dac88084304ff..2013fea01e0b56b057f85942c0606c02b472a941 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-04-29  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
>+        https://bugs.webkit.org/show_bug.cgi?id=185103
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Send a fake user agent to chase.com to make it work.
>+
>+        * platform/UserAgentQuirks.cpp:
>+        (WebCore::urlRequiresMacintoshPlatform):
>+        (WebCore::UserAgentQuirks::stringForQuirk): Also, remove this stale comment.
>+
> 2018-04-29  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Implement Display::Box functions
>diff --git a/Source/WebCore/platform/UserAgentQuirks.cpp b/Source/WebCore/platform/UserAgentQuirks.cpp
>index e347426a9c138198444d7eca1f39bc837ed2cf71..1fb2b1c363c7b049eff1a1c8fe9689507b766934 100644
>--- a/Source/WebCore/platform/UserAgentQuirks.cpp
>+++ b/Source/WebCore/platform/UserAgentQuirks.cpp
>@@ -93,6 +93,11 @@ static bool urlRequiresMacintoshPlatform(const URL& url)
>     if (baseDomain == "whatsapp.com")
>         return true;
> 
>+    // chase.com displays a huge "please update your browser" warning with
>+    // WebKitGTK+'s standard user agent.
>+    if (baseDomain == "chase.com")
>+        return true;
>+
>     // Microsoft Outlook Web App forces users with WebKitGTK+'s standard user
>     // agent to use the light version. Earlier versions even blocks users from
>     // accessing the calendar.
>@@ -133,7 +138,6 @@ String UserAgentQuirks::stringForQuirk(UserAgentQuirk quirk)
>         // Get versions from https://chromium.googlesource.com/chromium/src.git
>         return ASCIILiteral("Chrome/58.0.3029.81");
>     case NeedsMacintoshPlatform:
>-        // Frozen per https://bugs.webkit.org/show_bug.cgi?id=180365
>         return ASCIILiteral("Macintosh; Intel Mac OS X 10_13_4");
>     case NeedsLinuxDesktopPlatform:
>         return ASCIILiteral("X11; Linux x86_64");
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 5f79440757d43bbc2a53367644569ddff278741a..404ce4162575f5a834d573da487ecb8f83b8d402 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-04-29  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
>+        https://bugs.webkit.org/show_bug.cgi?id=185103
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
>+        (TestWebKitAPI::TEST):
>+
> 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
> 
>         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
>diff --git a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>index 2a1769e3f9787a3025d185479eab5e8a96874889..bdab3dc8d89f98f6ea9f2fee565c506fbf81e17f 100644
>--- a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>@@ -93,6 +93,7 @@ TEST(UserAgentTest, Quirks)
>     assertUserAgentForURLHasMacPlatformQuirk("http://www.whatsapp.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://web.whatsapp.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://outlook.live.com/");
>+    assertUserAgentForURLHasMacPlatformQuirk("http://www.chase.com/");
> }
> 
> } // namespace TestWebKitAPI

Actions: View | Formatted Diff | Diff

Attachments on bug 185103: 339099