Attachment 339079 Details for Bug 185115 – Patch

[patch] Patch

bug-185115-20180428162002.patch (text/plain), 2.86 KB, created by corydoras on 2018-04-28 16:20:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: corydoras

Created: 2018-04-28 16:20:03 PDT

Size: 2.86 KB

patch

obsolete

>Subversion Revision: 231131
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index b3474d05e20bd694553fe621a56875a0a578b3f4..6bc1e4094fef99dcdd10d4c2bdce57c08e4aab55 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-04-28  Peter Ammon  <corydoras@ridiculousfish.com>
>+
>+        Math.round() produces wrong result for value prior to 0.5
>+        https://bugs.webkit.org/show_bug.cgi?id=185115
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/MathCommon.cpp:
>+
> 2018-04-27  Caio Lima  <ticaiolima@gmail.com>
> 
>         [ESNext][BigInt] Implement support for "*" operation
>diff --git a/Source/JavaScriptCore/runtime/MathCommon.cpp b/Source/JavaScriptCore/runtime/MathCommon.cpp
>index bdf1487ec1ee79dab553f353ba515f623c5a959d..c0d7bcc9f293047ae0f90284e44870c383b6fcd4 100644
>--- a/Source/JavaScriptCore/runtime/MathCommon.cpp
>+++ b/Source/JavaScriptCore/runtime/MathCommon.cpp
>@@ -490,8 +490,8 @@ static inline bool isStrictInt32(double value)
> extern "C" {
> double jsRound(double value)
> {
>-    double integer = ceil(value);
>-    return integer - (integer - value > 0.5);
>+    double integer = floor(value);
>+    return copysign(integer + (value - integer >= 0.5), value);
> }
> 
> #if CALLING_CONVENTION_IS_STDCALL || CPU(ARM_THUMB2)
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index 1bdb91c71ce44cf7de60a8f7960ae5392fcc3a33..838e14b8dd79fb03ca3f94855af905ead5eab7aa 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-04-28  Peter Ammon  <corydoras@ridiculousfish.com>
>+
>+        Math.round() produces wrong result for value prior to 0.5
>+        https://bugs.webkit.org/show_bug.cgi?id=185115
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * stress/math-round-basics.js:
>+
> 2018-04-27  Caio Lima  <ticaiolima@gmail.com>
> 
>         [ESNext][BigInt] Implement support for "*" operation
>diff --git a/JSTests/stress/math-round-basics.js b/JSTests/stress/math-round-basics.js
>index f61a6d4f4769585fe5b9f56ff0eabc402302413c..f301eae96946c2e0b856c5d4d4e49b86df430a72 100644
>--- a/JSTests/stress/math-round-basics.js
>+++ b/JSTests/stress/math-round-basics.js
>@@ -69,6 +69,14 @@ for (var i = 0; i < 1e4; ++i) {
>     if (!(roundedValue === 0 && (1/roundedValue) === -Infinity))
>         throw "mathRoundOnDoubles(-0) = " + roundedValue;
> 
>+    var roundedValue = mathRoundOnDoubles(0.499999999999999944);
>+    if (!(roundedValue === 0 && (1/roundedValue) === Infinity))
>+        throw "mathRoundOnDoubles(0.499999999999999944) = " + roundedValue;
>+
>+    var roundedValue = mathRoundOnDoubles(-0.499999999999999944);
>+    if (!(roundedValue === 0 && (1/roundedValue) === -Infinity))
>+        throw "mathRoundOnDoubles(-0.499999999999999944) = " + roundedValue;
>+
>     var roundedValue = mathRoundOnDoubles(NaN);
>     if (roundedValue === roundedValue)
>         throw "mathRoundOnDoubles(NaN) = " + roundedValue;

Actions: View | Formatted Diff | Diff

Attachments on bug 185115: 339079 | 339080 | 378145 | 378241