WebKit Bugzilla
Attachment 339040 Details for
Bug 185098
: Implement color-filter for text stroke
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185098-20180427165431.patch (text/plain), 4.40 KB, created by
Simon Fraser (smfr)
on 2018-04-27 16:54:32 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Simon Fraser (smfr)
Created:
2018-04-27 16:54:32 PDT
Size:
4.40 KB
patch
obsolete
>Subversion Revision: 231112 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index ef188db6866532b47100a13f7c66e327c1ff1106..758f98959fb4e4e5de94f78aeb673992b620e79b 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,17 @@ >+2018-04-27 Simon Fraser <simon.fraser@apple.com> >+ >+ Implement color-filter for text stroke >+ https://bugs.webkit.org/show_bug.cgi?id=185098 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Transform the text stroke color through color-filter. >+ >+ Test: css3/color-filters/color-filter-text-stroke.html >+ >+ * rendering/TextPaintStyle.cpp: >+ (WebCore::computeTextPaintStyle): >+ > 2018-04-27 Simon Fraser <simon.fraser@apple.com> > > Implement animation for color-filter >diff --git a/Source/WebCore/rendering/TextPaintStyle.cpp b/Source/WebCore/rendering/TextPaintStyle.cpp >index 28f83f8444bc28ff947d3196fe5ebf7dc11db425..d748f55fd3ded52b8f61b42e06171a61e4663ad9 100644 >--- a/Source/WebCore/rendering/TextPaintStyle.cpp >+++ b/Source/WebCore/rendering/TextPaintStyle.cpp >@@ -120,7 +120,7 @@ TextPaintStyle computeTextPaintStyle(const Frame& frame, const RenderStyle& line > if (forceBackgroundToWhite) > paintStyle.fillColor = adjustColorForVisibilityOnBackground(paintStyle.fillColor, Color::white); > >- paintStyle.strokeColor = lineStyle.computedStrokeColor(); >+ paintStyle.strokeColor = lineStyle.colorByApplyingColorFilter(lineStyle.computedStrokeColor()); > > // Make the text stroke color legible against a white background > if (forceBackgroundToWhite) >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 1a5b39b9dede214ba6765ac620396c516d09d03a..1eb0ad589a35446c705634e1cc02d85aea8e2baa 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,13 @@ >+2018-04-27 Simon Fraser <simon.fraser@apple.com> >+ >+ Implement color-filter for text stroke >+ https://bugs.webkit.org/show_bug.cgi?id=185098 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * css3/color-filters/color-filter-text-stroke-expected.html: Added. >+ * css3/color-filters/color-filter-text-stroke.html: Added. >+ > 2018-04-27 Simon Fraser <simon.fraser@apple.com> > > Implement animation for color-filter >diff --git a/LayoutTests/css3/color-filters/color-filter-text-stroke-expected.html b/LayoutTests/css3/color-filters/color-filter-text-stroke-expected.html >new file mode 100644 >index 0000000000000000000000000000000000000000..a1ceee630759c2a19a1027b2abb52710982c956d >--- /dev/null >+++ b/LayoutTests/css3/color-filters/color-filter-text-stroke-expected.html >@@ -0,0 +1,19 @@ >+<!DOCTYPE html> >+<html> >+ <head> >+ <title>CSS Test: color-filter reference</title> >+ <link rel="author" title="Apple" href="http://www.apple.com/"> >+ <style type="text/css"> >+ .test >+ { >+ margin: 50px 20px; >+ font: 120px Ahem; >+ color: green; >+ } >+ </style> >+ </head> >+ <body> >+ <div class="test" style="stroke-color: blue; stroke-width: 20px;">O</div> >+ <div class="test" style="-webkit-text-stroke: 20px blue;">O</div> >+ </body> >+</html> >diff --git a/LayoutTests/css3/color-filters/color-filter-text-stroke.html b/LayoutTests/css3/color-filters/color-filter-text-stroke.html >new file mode 100644 >index 0000000000000000000000000000000000000000..18db6e95b8287f460a06d0efeb761913448ddf65 >--- /dev/null >+++ b/LayoutTests/css3/color-filters/color-filter-text-stroke.html >@@ -0,0 +1,27 @@ >+<!DOCTYPE html> >+<html> >+ <head> >+ <title>CSS Test: color-filter affects text stroke</title> >+ <link rel="author" title="Apple" href="http://www.apple.com/"> >+ <link rel="match" href="color-filter-text-decoration-shadow-expected.html"> >+ >+ <meta name="assert" content="color-filter affects text stroke"> >+ <style type="text/css"> >+ .test >+ { >+ margin: 50px 20px; >+ font: 120px Ahem; >+ color: rgb(255, 128, 255); >+ color-filter: invert(); >+ } >+ </style> >+ <script> >+ if (window.internals) >+ internals.settings.setColorFilterEnabled(true); >+ </script> >+ </head> >+ <body> >+ <div class="test" style="stroke-color: yellow; stroke-width: 20px;">O</div> >+ <div class="test" style="-webkit-text-stroke: 20px yellow;">O</div> >+ </body> >+</html>
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
zalan
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185098
: 339040