Attachment 339039 Details for Bug 185097 – Patch

[patch] Patch

bug-185097-20180427164116.patch (text/plain), 1.79 KB, created by Timothy Hatcher on 2018-04-27 16:41:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2018-04-27 16:41:16 PDT

Size: 1.79 KB

patch

obsolete

>Subversion Revision: 231064
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 21c5fbc04b8496e200c7623c2919644ab72c810a..702759486c0f4bfb66354f8ba1ca5d81e2e6acc6 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-04-27  Timothy Hatcher  <timothy@apple.com>
>+
>+        REGRESSION: Touch events fail to dispatch to the page in all cases.
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=185097
>+        rdar://problem/39731995
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
>+        Consult internal gesture recognizers, otherwise NO might get returned.
>+
> 2018-04-26  Jer Noble  <jer.noble@apple.com>
> 
>         WK_COCOA_TOUCH all the things.
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index ba1bf5b70b1ea4d3d1525693ff3d630623d495df..56850d38fefceae90bcdc31436ebc5cd7feb5407 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -1334,6 +1334,11 @@ static inline bool isSamePair(UIGestureRecognizer *a, UIGestureRecognizer *b, UI
> 
> - (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:(UIGestureRecognizer*)otherGestureRecognizer
> {
>+#if USE(APPLE_INTERNAL_SDK)
>+    if ([self _internalGestureRecognizer:gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:otherGestureRecognizer])
>+        return YES;
>+#endif
>+
>     if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _longPressGestureRecognizer.get()))
>         return YES;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185097: 339039