Attachment 339015 Details for Bug 184469 – Patch

[patch] Patch

bug-184469-20180427124731.patch (text/plain), 2.96 KB, created by youenn fablet on 2018-04-27 12:47:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-04-27 12:47:31 PDT

Size: 2.96 KB

patch

obsolete

>Subversion Revision: 230995
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 84474f93ba45aca9ecad434fbec146691593b3a8..9f30beceb7b85ec35c2515898d02d5f439b784af 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-04-27  Youenn Fablet  <youenn@apple.com>
>+
>+        Layout Test http/wpt/service-workers/header-filtering.https.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=184469
>+        <rdar://problem/39428226>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Ensure that the message posted for the loading of the initial iframe is actuall received before doing further tests.
>+
>+        * http/wpt/service-workers/header-filtering.https.html:
>+        * platform/mac-wk2/TestExpectations:
>+
> 2018-04-26  Youenn Fablet  <youenn@apple.com>
> 
>         Use NetworkLoadChecker for XHR/fetch loads
>diff --git a/LayoutTests/http/wpt/service-workers/header-filtering.https.html b/LayoutTests/http/wpt/service-workers/header-filtering.https.html
>index e6b39bde92d0c56ddefa73d4b473e60d23075142..e844f90db854027ef350ad789e549d214be73f1e 100644
>--- a/LayoutTests/http/wpt/service-workers/header-filtering.https.html
>+++ b/LayoutTests/http/wpt/service-workers/header-filtering.https.html
>@@ -40,24 +40,31 @@ async function registerServiceWorker(scope)
>     });
> }
> 
>+var processMessage;
> promise_test(async (test) => {
>     registration = await registerServiceWorker(scope);
>     registration.active.postMessage("ready?");
>+
>+    navigator.serviceWorker.onmessage = (event) => {
>+        processMessage(event.data);
>+    };
>+
>     return new Promise((resolve) => {
>-        navigator.serviceWorker.onmessage = (event) => {
>+        processMessage = (data) => {
>             assert_equals(event.data, "ready");
>-            navigator.serviceWorker.onmessage = undefined;
>             resolve();
>-        };
>+        }
>     });
> }, "Prepare tests: setup worker and register the client");
> 
>-var processMessage;
> promise_test(async (test) => {
>+    const promise = new Promise((resolve) => {
>+        processMessage = (data) => {
>+            resolve(data);
>+        };
>+    });
>     frame = await withFrame(scope + "/header-filtering-iframe.html");
>-    navigator.serviceWorker.onmessage = (event) => {
>-        processMessage(event.data);
>-    };
>+    await promise;
> }, "Prepare tests: Add a frame controlled by service worker");
> 
> promise_test(async (test) => {
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index 946cbe34f4c262b24d0ddf8e38a97ab9e2e81c3e..a023d5755c2afc36d04a8c8647fe573a3a18f468 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -890,4 +890,3 @@ webkit.org/b/184051 fast/loader/submit-form-while-parsing-2.html [ Pass Timeout
> 
> webkit.org/b/177380 http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure ]
> 
>-webkit.org/b/184469 http/wpt/service-workers/header-filtering.https.html [ Pass Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 184469: 339015 | 339323 | 340709