Attachment 339011 Details for Bug 185034 – Proposed patch

[patch] Proposed patch

0001-WebCore-Document-convertAbsoluteToClientRect-dont-us.patch (text/plain), 1.01 KB, created by Juan Pablo Ugarte on 2018-04-27 11:49:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Juan Pablo Ugarte

Created: 2018-04-27 11:49:39 PDT

Size: 1.01 KB

patch

obsolete

>From 6208e1f72daa62efb6068e6aee05ef9b0b856589 Mon Sep 17 00:00:00 2001
>From: Juan Pablo Ugarte <ugarte@endlessm.com>
>Date: Fri, 27 Apr 2018 15:48:26 -0300
>Subject: [PATCH] WebCore::Document::convertAbsoluteToClientRect() dont use
> effectiveZoom
>
>getBoundingClientRect() return wrong values when CSS zoom is set because zoom
>is used as the effectiveZoom parameter to Document::convertAbsoluteToClientRects()
>---
> Source/WebCore/dom/Document.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
>index 0783c88..1f80088 100644
>--- a/Source/WebCore/dom/Document.cpp
>+++ b/Source/WebCore/dom/Document.cpp
>@@ -6834,7 +6834,7 @@ void Document::convertAbsoluteToClientRect(FloatRect& rect, const RenderStyle& s
>         return;
> 
>     const auto& frameView = *view();
>-    rect = frameView.absoluteToDocumentRect(rect, style.effectiveZoom());
>+    rect = frameView.absoluteToDocumentRect(rect);
>     rect = frameView.documentToClientRect(rect);
> }
> 
>-- 
>2.17.0
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185034: 338891 | 339011 | 339432 | 339444 | 339451 | 339464 | 339466 | 339476 | 339502