Attachment 339008 Details for Bug 185083 – Patch

[patch] Patch

bug-185083-20180427113255.patch (text/plain), 1.61 KB, created by Keith Miller on 2018-04-27 11:32:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2018-04-27 11:32:56 PDT

Size: 1.61 KB

patch

obsolete

>Subversion Revision: 231101
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index de2aa449ca5792a81320f11fff5c72bbfe8c4de1..be2b4883980388c4fea018e964f77a5ac81ada2f 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-04-27  Keith Miller  <keith_miller@apple.com>
>+
>+        Remove unneeded exception check from String.fromCharCode
>+        https://bugs.webkit.org/show_bug.cgi?id=185083
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/StringConstructor.cpp:
>+        (JSC::stringFromCharCode):
>+
> 2018-04-26  Caio Lima  <ticaiolima@gmail.com>
> 
>         [ESNext][BigInt] Implement support for "*" operation
>diff --git a/Source/JavaScriptCore/runtime/StringConstructor.cpp b/Source/JavaScriptCore/runtime/StringConstructor.cpp
>index 10abc76105d2b0d0eea98259f70c2d493add90aa..0b10d8f40b8363cbd04368986c339b59512b209e 100644
>--- a/Source/JavaScriptCore/runtime/StringConstructor.cpp
>+++ b/Source/JavaScriptCore/runtime/StringConstructor.cpp
>@@ -77,9 +77,9 @@ static EncodedJSValue JSC_HOST_CALL stringFromCharCode(ExecState* exec)
> 
>     unsigned length = exec->argumentCount();
>     if (LIKELY(length == 1)) {
>-        unsigned code = exec->uncheckedArgument(0).toUInt32(exec);
>-        RETURN_IF_EXCEPTION(scope, encodedJSValue());
>         scope.release();
>+        unsigned code = exec->uncheckedArgument(0).toUInt32(exec);
>+        // Not checking for an exception here is ok because jsSingleCharacterString will just fetch an unused string if there's an exception.
>         return JSValue::encode(jsSingleCharacterString(exec, code));
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185083: 339007 | 339008