Attachment 339005 Details for Bug 185040 – Patch

[patch] Patch

bug-185040-20180427105250.patch (text/plain), 1.54 KB, created by Chris Dumez on 2018-04-27 10:52:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-04-27 10:52:50 PDT

Size: 1.54 KB

patch

obsolete

>Subversion Revision: 231101
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c98d01b98a327c6fbc0bbd78238d424caf935f45..cfb66b184b751d897d17169ae2948d57284bff40 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-04-27  Chris Dumez  <cdumez@apple.com>
>+
>+        Regression(r222392?): Events can have a negative timestamp which causes app breakage
>+        https://bugs.webkit.org/show_bug.cgi?id=185040
>+        <rdar://problem/39638051>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The real fix is in UIKit when generating the touch timestamps. However, this patch
>+        does some hardening to make sure that Event.timestamp can never return a negative
>+        value even if something goes wrong.
>+
>+        * dom/Event.cpp:
>+        (WebCore::Event::timeStampForBindings const):
>+
> 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
> 
>         Fix color-filter to apply to text decorations
>diff --git a/Source/WebCore/dom/Event.cpp b/Source/WebCore/dom/Event.cpp
>index 88c4381e9a7bf6a83a365eb15a1725ced283e291..c67822aab92de19ffcd31925186151089bca2b17 100644
>--- a/Source/WebCore/dom/Event.cpp
>+++ b/Source/WebCore/dom/Event.cpp
>@@ -170,7 +170,7 @@ DOMHighResTimeStamp Event::timeStampForBindings(ScriptExecutionContext& context)
>     if (!performance)
>         return 0;
> 
>-    return performance->relativeTimeFromTimeOriginInReducedResolution(m_createTime);
>+    return std::max(performance->relativeTimeFromTimeOriginInReducedResolution(m_createTime), 0.);
> }
> 
> void Event::resetBeforeDispatch()

Actions: View | Formatted Diff | Diff

Attachments on bug 185040: 339005