Attachment 338990 Details for Bug 184758 – Patch

[patch] Patch

bug-184758-20180427102902.patch (text/plain), 6.50 KB, created by cvazac on 2018-04-27 08:29:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: cvazac

Created: 2018-04-27 08:29:03 PDT

Size: 6.50 KB

patch

obsolete

>Subversion Revision: 231084
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index bc57ac471c61216b8f929037ba0dc5d27e30527c..f814d6df4faf00a0edfbb6c113c1f75e289734b6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-04-26  Charles Vazac  <cvazac@gmail.com>
>+
>+        Runtime feature flag for Server-Timing
>+        https://bugs.webkit.org/show_bug.cgi?id=184758
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/RuntimeEnabledFeatures.h:
>+        (WebCore::RuntimeEnabledFeatures::setServerTimingEnabled):
>+        (WebCore::RuntimeEnabledFeatures::serverTimingEnabled const):
>+
> 2018-04-26  Justin Fan  <justin_fan@apple.com>
> 
>         tex[Sub]Image2D slow when passing in a <canvas>, faster with ImageData.
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 2003f921af046bd1dd1d70606dd7cd76fee9562c..5824b391b4f29a03de476e7c67fae43798af4d7a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-04-26  Charles Vazac  <cvazac@gmail.com>
>+
>+        Runtime feature flag for Server-Timing
>+        https://bugs.webkit.org/show_bug.cgi?id=184758
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml: added ServerTimingEnabled flag.
>+        * UIProcess/API/C/WKPreferences.cpp:
>+        (WKPreferencesSetServerTimingEnabled):
>+        * UIProcess/API/C/WKPreferencesRefPrivate.h: WK_EXPORT for WKPreferencesSetServerTimingEnabled.
>+
> 2018-04-26  Megan Gardner  <megan_gardner@apple.com>
> 
>         Add timeout for ensurePositionInformationIsUpToDate
>diff --git a/Source/WebCore/page/RuntimeEnabledFeatures.h b/Source/WebCore/page/RuntimeEnabledFeatures.h
>index 35a3b8f072e9caa84a9c852b523bdbb929d0cd41..8db903602bbbeed6237911de0f8a5be4b2c9e5fa 100644
>--- a/Source/WebCore/page/RuntimeEnabledFeatures.h
>+++ b/Source/WebCore/page/RuntimeEnabledFeatures.h
>@@ -253,6 +253,9 @@ public:
>     void setFromOriginResponseHeaderEnabled(bool isEnabled) { m_fromOriginResponseHeaderEnabled = isEnabled; }
>     bool fromOriginResponseHeaderEnabled() const { return m_fromOriginResponseHeaderEnabled; }
> 
>+    void setServerTimingEnabled(bool isEnabled) { m_isServerTimingEnabled = isEnabled; }
>+    bool serverTimingEnabled() const { return m_isServerTimingEnabled; }
>+
>     WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures();
> 
> private:
>@@ -389,6 +392,8 @@ private:
> 
>     bool m_fromOriginResponseHeaderEnabled { false };
> 
>+    bool m_isServerTimingEnabled { false };
>+
>     friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>;
> };
> 
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index b5f62c70cb7d3d2b0e1ead316a6a6e52291e65e0..0f68a761212b2f93c7d1c6f230d2fa3032c2a4ab 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1246,5 +1246,11 @@ FromOriginResponseHeaderEnabled:
>     defaultValue: false
>     humanReadableName: "From-Origin Response Header"
>     humanReadableDescription: "Support for the From-Origin Response Header"
>+
>+ServerTimingEnabled:
>+    type: bool
>+    defaultValue: true
>+    humanReadableName: "Server Timing"
>+    humanReadableDescription: "Enable Server API"
>     category: experimental
>     webcoreBinding: RuntimeEnabledFeatures
>diff --git a/Source/WebKit/UIProcess/API/C/WKPreferences.cpp b/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
>index edd474fe4d9d4e259e42ba879a042443958d9d4c..8209618c4cb0c1ef5d6c02940f8a91caac18cf22 100644
>--- a/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
>+++ b/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
>@@ -1983,3 +1983,8 @@ bool WKPreferencesGetRestrictedHTTPResponseAccess(WKPreferencesRef preferencesRe
> {
>     return toImpl(preferencesRef)->restrictedHTTPResponseAccess();
> }
>+
>+void WKPreferencesSetServerTimingEnabled(WKPreferencesRef preferencesRef, bool flag)
>+{
>+    toImpl(preferencesRef)->setServerTimingEnabled(flag);
>+}
>diff --git a/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h b/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>index 809b31891b2c501a013e6ae8937c1c787843e9c4..e8f549f6e2d0d5f732a6a8380a7885d2fa0ca375 100644
>--- a/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>+++ b/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>@@ -561,6 +561,9 @@ WK_EXPORT bool WKPreferencesGetShouldAllowUserInstalledFonts(WKPreferencesRef);
> WK_EXPORT void WKPreferencesSetAllowCrossOriginSubresourcesToAskForCredentials(WKPreferencesRef, bool flag);
> WK_EXPORT bool WKPreferencesGetAllowCrossOriginSubresourcesToAskForCredentials(WKPreferencesRef);
> 
>+// Defaults to false.
>+WK_EXPORT void WKPreferencesSetServerTimingEnabled(WKPreferencesRef, bool flag);
>+
> #ifdef __cplusplus
> }
> #endif
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 3018a411c75ee4f635f100342c71254918696772..4e4dcbfb46a2e62c53484cb6e3cb46c49dd9ee62 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-04-26  Charles Vazac  <cvazac@gmail.com>
>+
>+        Runtime feature flag for Server-Timing
>+        https://bugs.webkit.org/show_bug.cgi?id=184758
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
>+        * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
>+
> 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
>diff --git a/Tools/DumpRenderTree/win/DumpRenderTree.cpp b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>index ac6519f412c244a04f99268da6b40d887ac83722..5adc7eede2179d8c4e2cebe95926d5d16d11454d 100644
>--- a/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>+++ b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>@@ -786,6 +786,7 @@ static void enableExperimentalFeatures(IWebPreferences* preferences)
>     // FIXME: SubtleCrypto
>     prefsPrivate->setVisualViewportAPIEnabled(TRUE);
>     prefsPrivate->setWebAnimationsEnabled(TRUE);
>+    prefsPrivate->setServerTimingEnabled(TRUE);
>     // FIXME: WebGL2
>     // FIXME: WebRTC
> }
>diff --git a/Tools/WebKitTestRunner/TestController.cpp b/Tools/WebKitTestRunner/TestController.cpp
>index 68c49c841302dfc9bb1809b79294b6b1fb81d597..3fcfe63f319531fb2055632d6710783080ccaed5 100644
>--- a/Tools/WebKitTestRunner/TestController.cpp
>+++ b/Tools/WebKitTestRunner/TestController.cpp
>@@ -771,6 +771,8 @@ void TestController::resetPreferencesToConsistentValues(const TestOptions& optio
> 
>     WKPreferencesSetRestrictedHTTPResponseAccess(preferences, true);
> 
>+    WKPreferencesSetServerTimingEnabled(preferences, true);
>+
>     platformResetPreferencesToConsistentValues();
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 184758: 338263 | 338990 | 338996 | 339381 | 339383 | 339389 | 339725 | 339726 | 339732 | 339816 | 339818 | 339866 | 339880 | 339890 | 339891 | 339893 | 339908 | 339965 | 339970 | 339975 | 340025 | 340095 | 340096