Attachment 338971 Details for Bug 185069 – the patch

[patch] the patch

blah.patch (text/plain), 2.25 KB, created by Filip Pizlo on 2018-04-26 22:22:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2018-04-26 22:22:07 PDT

Size: 2.25 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 231086)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,24 @@
>+2018-04-26  Filip Pizlo  <fpizlo@apple.com>
>+
>+        Also run foldPathConstants before mussing up SSA
>+        https://bugs.webkit.org/show_bug.cgi?id=185069
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        This isn't needed now, but will be once I implement the phase in bug 185060.
>+        
>+        This could be a speed-up, or a slow-down, independent of that phase. Most likely it's neutral.
>+        Local testing seems to suggest that it's neutral. Anyway, whatever it ends up being, I want it to
>+        be landed separately and measured separately from that phase.
>+        
>+        It's probably nice for sanity to have this and reduceStrength run before tail duplication and
>+        another round of reduceStrength, since that make for something that is closer to a fixpoint. But
>+        it will increase FTL compile times. So, there's no way to guess if this change is good, bad, or
>+        neutral. It all depends on what programs typically look like.
>+
>+        * b3/B3Generate.cpp:
>+        (JSC::B3::generateToAir):
>+
> 2018-04-26  Caio Lima  <ticaiolima@gmail.com>
> 
>         [ESNext][BigInt] Implement support for "*" operation
>Index: Source/JavaScriptCore/b3/B3Generate.cpp
>===================================================================
>--- Source/JavaScriptCore/b3/B3Generate.cpp	(revision 230977)
>+++ Source/JavaScriptCore/b3/B3Generate.cpp	(working copy)
>@@ -1,5 +1,5 @@
> /*
>- * Copyright (C) 2015-2017 Apple Inc. All rights reserved.
>+ * Copyright (C) 2015-2018 Apple Inc. All rights reserved.
>  *
>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that the following conditions
>@@ -87,6 +87,8 @@ void generateToAir(Procedure& procedure)
>         hoistLoopInvariantValues(procedure);
>         if (eliminateCommonSubexpressions(procedure))
>             eliminateCommonSubexpressions(procedure);
>+        foldPathConstants(procedure);
>+        reduceStrength(procedure);
>         inferSwitches(procedure);
>         duplicateTails(procedure);
>         fixSSA(procedure);

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185069: 338971