Attachment 338948 Details for Bug 185062 – Needs test

[patch] Needs test

bug-185062-20180426214151.patch (text/plain), 2.59 KB, created by Myles C. Maxfield on 2018-04-26 18:41:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2018-04-26 18:41:56 PDT

Size: 2.59 KB

patch

obsolete

>Subversion Revision: 230727
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 4d9512e32652d3cc0878ba36a73bf7897f4ff307..d1c29e22a3e29d69125078d2e229f9003bd4b37a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-04-26  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        Text shaping in the simple path is flipped in the y direction
>+        https://bugs.webkit.org/show_bug.cgi?id=185062
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * platform/graphics/Font.cpp:
>+        (WebCore::Font::applyTransforms const):
>+        * platform/graphics/WidthIterator.cpp:
>+        (WebCore::WidthIterator::applyFontTransforms):
>+
> 2018-04-17  Chris Dumez  <cdumez@apple.com>
> 
>         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
>diff --git a/Source/WebCore/platform/graphics/Font.cpp b/Source/WebCore/platform/graphics/Font.cpp
>index 30e5f3c09248440ae3ecd419ed3f555855ff8ed1..2e2ad390dcc9c014b41427fe0561eb2aa1730da4 100644
>--- a/Source/WebCore/platform/graphics/Font.cpp
>+++ b/Source/WebCore/platform/graphics/Font.cpp
>@@ -368,7 +368,6 @@ RefPtr<Font> Font::createScaledFont(const FontDescription& fontDescription, floa
> 
> bool Font::applyTransforms(GlyphBufferGlyph* glyphs, GlyphBufferAdvance* advances, size_t glyphCount, bool enableKerning, bool requiresShaping) const
> {
>-    // We need to handle transforms on SVG fonts internally, since they are rendered internally.
> #if PLATFORM(COCOA)
>     CTFontTransformOptions options = (enableKerning ? kCTFontTransformApplyPositioning : 0) | (requiresShaping ? kCTFontTransformApplyShaping : 0);
>     return CTFontTransformGlyphs(m_platformData.ctFont(), glyphs, reinterpret_cast<CGSize*>(advances), glyphCount, options);
>diff --git a/Source/WebCore/platform/graphics/WidthIterator.cpp b/Source/WebCore/platform/graphics/WidthIterator.cpp
>index 688978a369be79413bf4aa8972a7366e489cf2d3..5a8da01f47d7cb1715668bc8be6bb5247315c235 100644
>--- a/Source/WebCore/platform/graphics/WidthIterator.cpp
>+++ b/Source/WebCore/platform/graphics/WidthIterator.cpp
>@@ -114,6 +114,9 @@ inline float WidthIterator::applyFontTransforms(GlyphBuffer* glyphBuffer, bool l
> 
>     font->applyTransforms(glyphBuffer->glyphs(lastGlyphCount), advances + lastGlyphCount, glyphBufferSize - lastGlyphCount, m_enableKerning, m_requiresShaping);
> 
>+    for (unsigned i = lastGlyphCount; i < glyphBufferSize; ++i)
>+        advances[i].setHeight(advances[i].height() * -1);
>+
>     if (!ltr)
>         glyphBuffer->reverse(lastGlyphCount, glyphBufferSize - lastGlyphCount);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185062: 338948 | 339433 | 339439 | 339441 | 339445 | 339458 | 339475 | 339524