WebKit Bugzilla
Attachment 338919 Details for
Bug 185053
: Update code style guidelines to mention braced initialization style.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185053-20180426150621.patch (text/plain), 1.83 KB, created by
Ross Kirsling
on 2018-04-26 15:06:22 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Ross Kirsling
Created:
2018-04-26 15:06:22 PDT
Size:
1.83 KB
patch
obsolete
>Subversion Revision: 231072 >diff --git a/Websites/webkit.org/ChangeLog b/Websites/webkit.org/ChangeLog >index 34bf887ed1e7def14ae2a8dfc9a1171694df1bbc..61f9d91652b78eeba0b5815067f450724a09e2a4 100644 >--- a/Websites/webkit.org/ChangeLog >+++ b/Websites/webkit.org/ChangeLog >@@ -1,3 +1,14 @@ >+2018-04-26 Ross Kirsling <ross.kirsling@sony.com> >+ >+ Update code style guidelines to mention braced initialization style. >+ https://bugs.webkit.org/show_bug.cgi?id=185053 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * code-style.md: >+ Add a clause to the Spacing section about braced initialization. >+ (Also, fix an erroneous element ID on a neighboring line.) >+ > 2018-04-04 Andy Estes <aestes@apple.com> > > Unreviewed. Correct the path to merchant-validation-config.php. >diff --git a/Websites/webkit.org/code-style.md b/Websites/webkit.org/code-style.md >index 70b7c11476ad304c0f9ba789120095a7efccae22..75940674a90ef9046dd3e735ab17dcfba886ff5f 100644 >--- a/Websites/webkit.org/code-style.md >+++ b/Websites/webkit.org/code-style.md >@@ -234,7 +234,22 @@ f (a, b); > f( a, b ); > ``` > >-[](#spacing-function-paren) In Objective-C, do not place spaces between the start of a block and its arguments, or the start of a block and its opening brace. **Do** place a space between argument lists and the opening brace of the block. >+[](#spacing-braced-init) When initializing an object, place a space before the leading brace as well as between the braces and their content. >+ >+###### Right: >+ >+```cpp >+Foo foo { bar }; >+``` >+ >+###### Wrong: >+ >+```cpp >+Foo foo{ bar }; >+Foo foo {bar}; >+``` >+ >+[](#spacing-objc-block) In Objective-C, do not place spaces between the start of a block and its arguments, or the start of a block and its opening brace. **Do** place a space between argument lists and the opening brace of the block. > > ###### Right: >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185053
: 338919