Attachment 338906 Details for Bug 185007 – Patch for landing

[patch] Patch for landing

bug-185007-20180426130159.patch (text/plain), 1.87 KB, created by Jer Noble on 2018-04-26 13:02:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-04-26 13:02:02 PDT

Size: 1.87 KB

patch

obsolete

>Subversion Revision: 231034
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 81f7345cac1a482e6e345e3c19780f7eb13d5486..1ed3ab037e64f9666893f6c6b499ed8b7cb280a8 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-04-25  Jer Noble  <jer.noble@apple.com>
>+
>+        WK_COCOA_TOUCH the WK_ACCESSIBILITY_LDFLAGS
>+        https://bugs.webkit.org/show_bug.cgi?id=185007
>+        <rdar://problem/39735943>
>+
>+        Reviewed by Timothy Hatcher.
>+
>+        * Configurations/WebKit.xcconfig:
>+
> 2018-04-25  Jer Noble  <jer.noble@apple.com>
> 
>         WK_COCOA_TOUCH all the things.
>diff --git a/Source/WebKit/Configurations/WebKit.xcconfig b/Source/WebKit/Configurations/WebKit.xcconfig
>index aa4c5b54465062b1044b4cf7b4f15ae4f3463d05..0277ff0002eda380b1a8d9a70147f9baec6be1d9 100644
>--- a/Source/WebKit/Configurations/WebKit.xcconfig
>+++ b/Source/WebKit/Configurations/WebKit.xcconfig
>@@ -39,12 +39,9 @@ DYLIB_INSTALL_NAME_BASE_YES = $(DYLIB_INSTALL_NAME_BASE);
> 
> LIBRARY_SEARCH_PATHS = $(inherited) "$(LIBWEBRTC_LIBRARY_DIR)";
> 
>-WK_ACCESSIBILITY_LDFLAGS = $(WK_ACCESSIBILITY_LDFLAGS_$(WK_PLATFORM_NAME));
>-WK_ACCESSIBILITY_LDFLAGS_iphoneos = -lAccessibility;
>-WK_ACCESSIBILITY_LDFLAGS_iphonesimulator = $(WK_ACCESSIBILITY_LDFLAGS_iphoneos);
>-WK_ACCESSIBILITY_LDFLAGS_watchos = $(WK_ACCESSIBILITY_LDFLAGS_iphoneos);
>-WK_ACCESSIBILITY_LDFLAGS_appletvos = $(WK_ACCESSIBILITY_LDFLAGS_iphoneos);
>-WK_ACCESSIBILITY_LDFLAGS_macosx = $(WK_ACCESSIBILITY_LDFLAGS$(WK_MACOS_1014));
>+WK_ACCESSIBILITY_LDFLAGS = $(WK_ACCESSIBILITY_LDFLAGS_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));
>+WK_ACCESSIBILITY_LDFLAGS_COCOA_TOUCH_YES = -lAccessibility;
>+WK_ACCESSIBILITY_LDFLAGS_COCOA_TOUCH_NO = $(WK_ACCESSIBILITY_LDFLAGS$(WK_MACOS_1014));
> WK_ACCESSIBILITY_LDFLAGS_MACOS_SINCE_1014 = -weak_library /usr/lib/libAccessibility.dylib;
> 
> WK_APPKIT_LDFLAGS = $(WK_APPKIT_LDFLAGS_$(WK_PLATFORM_NAME));

Actions: View | Formatted Diff | Diff

Attachments on bug 185007: 338819 | 338906 | 338912