Attachment 338866 Details for Bug 185025 – Patch

[patch] Patch

bug-185025-20180426123120.patch (text/plain), 1.52 KB, created by Dominik Inführ on 2018-04-26 03:31:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dominik Inführ

Created: 2018-04-26 03:31:21 PDT

Size: 1.52 KB

patch

obsolete

>Subversion Revision: 230911
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 504a8aa3f405d68332611ad9f7cd769b557fa8da..c3f1ce1ce932ce94ee497bd875923e497f0fb8c1 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-04-26  Dominik Infuehr  <dinfuehr@igalia.com>
>+
>+        [MIPS] Fix branch offsets in branchNeg32
>+        https://bugs.webkit.org/show_bug.cgi?id=185025
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Two nops were removed in branch(Not)Equal in #183130 but the offset wasn't adjusted.
>+
>+        * assembler/MacroAssemblerMIPS.h:
>+        (JSC::MacroAssemblerMIPS::branchNeg32):
>+
> 2018-04-22  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSC] Remove ModuleLoaderPrototype
>diff --git a/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h b/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h
>index b946586f9624df4d3702126011a8a00367272782..524e550c289c831011fc207d754309c420b0b7bb 100644
>--- a/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h
>+++ b/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h
>@@ -2457,9 +2457,9 @@ public:
>                 nop
>             No_overflow:
>             */
>-            m_assembler.bgez(srcDest, 11);
>-            m_assembler.subu(srcDest, MIPSRegisters::zero, srcDest);
>             m_assembler.bgez(srcDest, 9);
>+            m_assembler.subu(srcDest, MIPSRegisters::zero, srcDest);
>+            m_assembler.bgez(srcDest, 7);
>             m_assembler.nop();
>             return jump();
>         }

Actions: View | Formatted Diff | Diff

Attachments on bug 185025: 338866