Attachment 338835 Details for Bug 185019 – Patch

[patch] Patch

bug-185019-20180425173618.patch (text/plain), 1.58 KB, created by Ross Kirsling on 2018-04-25 17:36:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2018-04-25 17:36:19 PDT

Size: 1.58 KB

patch

obsolete

>Subversion Revision: 231014
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index bb5f3ef996e3f11b78a4226c62dc507db5da5b38..aa108455a4797fe8e9776553723281ffc3fbd4e7 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-04-25  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        WinCairo test bots should run JSC tests with options for Windows command prompt.
>+        https://bugs.webkit.org/show_bug.cgi?id=185019
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/build.webkit.org-config/steps.py:
>+        (RunJavaScriptCoreTests.start):
>+
> 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [WPE] Remove deprecated functions and properties from the API
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>index 2baed58673049530fc3bf4098b99139ce2157765..bfc3147a41d9ca5fbd1781546068a2319f7a217d 100644
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>@@ -318,6 +318,10 @@ class RunJavaScriptCoreTests(TestWithFailureCount):
>         # Check: https://bugs.webkit.org/show_bug.cgi?id=175140
>         if platform in ('gtk', 'wpe'):
>             self.setCommand(self.command + ['--memory-limited'])
>+        # WinCairo uses the Windows command prompt, not Cygwin.
>+        elif platform == 'wincairo':
>+            self.setCommand(self.command + ['--ruby-runner', '--test-writer=ruby'])
>+
>         appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))
>         return shell.Test.start(self)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185019: 338835