Attachment 338833 Details for Bug 185017 – Patch

[patch] Patch

bug-185017-20180425172226.patch (text/plain), 1.98 KB, created by Megan Gardner on 2018-04-25 17:22:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2018-04-25 17:22:26 PDT

Size: 1.98 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 231035)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-04-25  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Activate selection when interacting with editable content
>+        https://bugs.webkit.org/show_bug.cgi?id=185017
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        Fixes a regression from r231016 where selection now does not work when interacting with
>+        editable content. When we go into editable content, we should turn on the assistant.
>+        This fulfills the requirement of user interaction as well, so any javascript selecitons
>+        after this point should be valid.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _startAssistingKeyboard]):
>+        (-[WKContentView _stopAssistingKeyboard]):
>+
> 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
>Index: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>===================================================================
>--- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(revision 231016)
>+++ Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(working copy)
>@@ -3967,6 +3967,9 @@ - (void)takeTraitsFrom:(UITextInputTrait
> - (void)_startAssistingKeyboard
> {
>     [self useSelectionAssistantWithGranularity:WKSelectionGranularityCharacter];
>+    
>+    if (self.isFirstResponder && !self.suppressAssistantSelectionView)
>+        [_textSelectionAssistant activateSelection];
> 
> #if !ENABLE(EXTRA_ZOOM_MODE)
>     [self reloadInputViews];
>@@ -3976,6 +3979,8 @@ - (void)_startAssistingKeyboard
> - (void)_stopAssistingKeyboard
> {
>     [self useSelectionAssistantWithGranularity:_webView._selectionGranularity];
>+    
>+    [_textSelectionAssistant deactivateSelection];
> }
> 
> - (const AssistedNodeInformation&)assistedNodeInformation

Actions: View | Formatted Diff | Diff

Attachments on bug 185017: 338833 | 338852 | 338862